qgis-2.0.1/src/gui/qgscomposerview.cpp: 2* bad if test ?

[qgib]

Author Name: David Binderman (David Binderman)
Original Redmine Issue: 9285
Affected QGIS version: 2.0.1

---

I just ran the static analyser "cppcheck" over the
source code of qgis-2.0.1

It said many things, including

qgis-2.0.1/src/gui/qgscomposerview.cpp:226]: (style) Same expression on both sides of '||'.

Source code is

if ( !mRubberBandItem || mRubberBandItem->rect().width() < 0.1 || mRubberBandItem->rect().width() < 0.1 )

Maybe

if ( !mRubberBandItem || mRubberBandItem->rect().width() < 0.1 || mRubberBandItem->rect().height() < 0.1 )

might be better code.

qgis-2.0.1/src/gui/qgscomposerview.cpp:318]: (style) Same expression on both sides of '||'.

Duplicate.

[qgib]

Author Name: Nyall Dawson (@nyalldawson)

---

Fixed in changeset "bee12917270c5d286ff0915c727381eb08e9e017".

---

• status_id was changed from Open to Closed

[qgib]

Author Name: Nyall Dawson (@nyalldawson)

---

Good catch -- thanks!