Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addDrawingOrder changed in 2.4 breaks LayerDrawingOrder logic #19028

Closed
qgib opened this issue Jun 18, 2014 · 2 comments
Closed

addDrawingOrder changed in 2.4 breaks LayerDrawingOrder logic #19028

qgib opened this issue Jun 18, 2014 · 2 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Jun 18, 2014

Author Name: Giovanni Allegri (@giohappy)
Original Redmine Issue: 10625
Affected QGIS version: 2.2.0
Redmine category:qgis_server
Assignee: Marco Hugentobler


I'm investingating why QWC is giving me problems with QGIS Server 2.4.
I've spot a difference between QGIS 2.2 and the master code which seems to cause problems during the GetProjectSettings response parsing.

In previous versions of QGIS Server addDrawingOrder worked for project layers [1] while for embedded layers we had addDrawingOrderEmbeddedGroup [2].
Now we have only addDrawingOrder which seems to work only for embedded projects.
The result is that, without emdedded layers, the element will always be empty.

This seems to cause some problems on the QWC side. In fact now QWC works only with GetCapabilities, while it worked both with GetCapabilities and GetProjectSettings before.

[1] https://github.com/qgis/QGIS/blob/release-2_2/src/mapserver/qgsprojectparser.cpp#L3644
[2] https://github.com/qgis/QGIS/blob/release-2_2/src/mapserver/qgsprojectparser.cpp#L4067
[3] https://github.com/qgis/QGIS/blob/master/src/mapserver/qgswmsprojectparser.cpp#L674

@qgib
Copy link
Contributor Author

qgib commented Jun 18, 2014

Author Name: Giovanni Allegri (@giohappy)


I suggest this pull request #1462

@qgib
Copy link
Contributor Author

qgib commented Jun 18, 2014

Author Name: Marco Hugentobler (@mhugent)


Fixed in changeset "c05e342ab1fc09a1f9f09cf76840862dc3e038cf".


  • status_id was changed from Open to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server labels May 25, 2019
@qgib qgib added this to the Version 2.4 milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Projects
None yet
Development

No branches or pull requests

1 participant