Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation error in qgis:creategrid and associated errors it Hex grid from layer script #20024

Closed
qgib opened this issue Dec 6, 2014 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Dec 6, 2014

Author Name: ramon . (ramon .)
Original Redmine Issue: 11800
Affected QGIS version: 2.6.1
Redmine category:processing/core
Assignee: Victor Olaya


Running the "Hex grid from layer" script gives this error:

Oooops! The following output layers could not be open
grid: /tmp/processing/1429ad65364842438cdb2532e93107f5/grid.shp
The above files could not be opened, which probably indicates that
they were not correctly produced by the executed algorithm
Checking the log information might help you see why those layers were
not created as expected

The log helpfully suggests:

Horizontal spacing is too small for the covered area

Running the "Create Grid" gui with the same values gives this in the log:

#ALGORITHM|Sat Dec 06 2014 18:31:27|processing.runalg("qgis:creategrid",3,7829,10226,200,200,353075,6595874,"EPSG:28351","/home/user/temp.shp")

which is to say
processing.runalg("qgis:creategrid", gridtype, width, height, hspacing, vspacing, centerx, centery, CRStype, savename)

This is different to the documentation
processing.runalg('qgis:creategrid', hspacing, vspacing, width, height, centerx, centery, gridtype, savename)

which the "Hex grid from layer" script follows
processing.runalg('qgis:creategrid', cellsize, cellsize, width, height, centerx, centery, 3, input.crs().authid(), grid)

I'll assume qgis:creategrid alg is correct and the documentation needs an update (if you can point me in the right direction I can do that), and am providing a patch for the "Hex grid from layers" script


@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2014

Author Name: ramon . (ramon .)


I notice I've not been clear about which docs I'm talking about.

The documentation in the user guide is correct.
It's the in application that needs an update.

The patch for the script adjusts the script to fit the user manual docs and the information from the algorithm in the log.

@qgib
Copy link
Contributor Author

qgib commented Dec 7, 2014

Author Name: ramon . (ramon .)


I see in this thread http://lists.osgeo.org/pipermail/qgis-community-team/2014-December/004001.html that the documentation in >2.7 will be pointing to the user manual descriptions, and therefore should be correct (or at least more than it is now.

Clearly, I've not been paying enough attention, and am making un-needed noise about the docs bit.

@qgib
Copy link
Contributor Author

qgib commented Dec 8, 2014

Author Name: Giovanni Manghi (@gioman)


will be fixed when this PR will be committed

qgis/QGIS-Processing#6

but closing because anyway this script is not part of qgis source code, but belongs to the QGIS-processing scripts repository.


  • resolution was changed from to fixed/implemented
  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Dec 8, 2014

Author Name: ramon . (ramon .)


Thanks.

I presumed, that since it was part of processing it lived in here somewhere...

At least I know where to put something like this next time.

@qgib
Copy link
Contributor Author

qgib commented Jun 7, 2015

Author Name: Giovanni Manghi (@gioman)


  • category_id was changed from 94 to Processing/Core

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 25, 2019
@qgib qgib added this to the Version 2.8 milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant