Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X GRASS 7 processing command wrong setup #23568

Closed
qgib opened this issue Sep 30, 2016 · 1 comment
Closed

OS X GRASS 7 processing command wrong setup #23568

qgib opened this issue Sep 30, 2016 · 1 comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Sep 30, 2016

Author Name: William Kyngesburye (@kyngchaos)
Original Redmine Issue: 15645
Affected QGIS version: 2.16.3
Redmine category:processing/grass
Assignee: Victor Olaya


Commit #e1ff6e896a8178c2f61930535ca91a408c3e2355 tried to fix GRASS 7 detection on OS X but for some reason inserted * around the command filename, ie grass.sh. This results in the test to fail and the nix grass70 command to be used, which then fails to run.

The Mac test block in Grass7Utils.py : prepareGrass7Execution() should be:

            if isMac() and os.path.exists(Grass7Utils.grassPath() + os.sep + 'grass.sh'):
                command = Grass7Utils.grassPath() + os.sep + 'grass.sh ' \\
                    + Grass7Utils.grassMapsetFolder() + '/PERMANENT'

The commit was before 2.16, so it affects both master and 2.16. Also, it should be backported (corrected) to 2.14.

@qgib
Copy link
Contributor Author

qgib commented Oct 4, 2016

Author Name: Alexander Bruy (@alexbruy)


Fixed in changeset "d03d2069b96b2c25abe64588f54f24dab7ea7cc2".


  • status_id was changed from Open to Closed

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS labels May 25, 2019
@qgib qgib added this to the Version 2.16 milestone May 25, 2019
@qgib qgib closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GRASS
Projects
None yet
Development

No branches or pull requests

1 participant