Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken io_gdal raster import in SAGA LTR package shipped with OSGeo4W #24332

Closed
qgib opened this issue Apr 7, 2017 · 10 comments
Closed

Broken io_gdal raster import in SAGA LTR package shipped with OSGeo4W #24332

qgib opened this issue Apr 7, 2017 · 10 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Build/Install Related to compiling or installing QGIS High Priority Regression Something which used to work, but doesn't anymore
Milestone

Comments

@qgib
Copy link
Contributor

qgib commented Apr 7, 2017

Author Name: Giovanni Manghi (@gioman)
Original Redmine Issue: 16423
Affected QGIS version: 2.18.7
Redmine category:build/install


This is a really weird issue. This ticket is meant to replace #24317 for sake of clarity.

This only affects Windows.

  1. In OSGeo4w installer the option for SAGA LTR says "2.3.1", but once installed "saga_cmd" says 2.3.2, which is weird per se as SAGA 2.3.2 does not exist:

https://sourceforge.net/projects/saga-gis/files/SAGA%20-%202.3/

  1. if launching SAGA GUI of this SAGA installation it apparently seems all ok, but for instance it misses the "Import > GDAL/OGR" tools which are available in any older and newer (or even the same) versions downloaded from SAGA site. This could be related to the next point, that is the more important

  2. In this OSGEo4W SAGA LTR install the raster import operation (done with the "io_gdal" module) produces a WRONG raster, where 1 are replaced with NULLs. This DOES NOT happen in any older and newer (or even the same) versions downloaded from SAGA site. This is of course a deal breaker for Processing because it calls io_gdal any time a SAGA raster tool is used

You can test with this input

https://cld.pt/dl/download/6ac21f8c-0244-45a5-823e-6047bb99b208/bacias_lee_2014_2018_17_Binary.tif

and this command

saga_cmd io_gdal 0 -TRANSFORM 1 -RESAMPLING 0 -GRIDS "imported_raster.sgrd" -FILES "bacias_lee_2014_2018_17_Binary.tif"


Related issue(s): #24331 (relates)
Redmine related issue(s): 16422


@qgib
Copy link
Contributor Author

qgib commented Apr 7, 2017

Author Name: Jürgen Fischer (@jef-n)


OSGeo4W issues...


  • resolution was changed from to up/downstream

@qgib
Copy link
Contributor Author

qgib commented Apr 7, 2017

Author Name: Giovanni Manghi (@gioman)


Jürgen Fischer wrote:

OSGeo4W issues...

"OSGeo4W !#10586":https://trac.osgeo.org/osgeo4w/ticket/527


  • resolution was changed from up/downstream to

@qgib
Copy link
Contributor Author

qgib commented Apr 7, 2017

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to up/downstream

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • regression was configured as 1

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Severe/Regression to High

@qgib
Copy link
Contributor Author

qgib commented Apr 30, 2017

Author Name: Giovanni Manghi (@gioman)


  • easy_fix was configured as 0

@qgib
Copy link
Contributor Author

qgib commented May 3, 2017

Author Name: Giovanni Manghi (@gioman)


This only affects Windows.

  1. In OSGeo4w installer the option for SAGA LTR says "2.3.1", but once installed "saga_cmd" says 2.3.2, which is weird per se as SAGA 2.3.2 does not exist:

https://sourceforge.net/projects/saga-gis/files/SAGA%20-%202.3/

  1. if launching SAGA GUI of this SAGA installation it apparently seems all ok, but for instance it misses the "Import > GDAL/OGR" tools which are available in any older and newer (or even the same) versions downloaded from SAGA site. This could be related to the next point, that is the more important

  2. In this OSGEo4W SAGA LTR install the raster import operation (done with the "io_gdal" module) produces a WRONG raster, where 1 are replaced with NULLs. This DOES NOT happen in any older and newer (or even the same) versions downloaded from SAGA site. This is of course a deal breaker for Processing because it calls io_gdal any time a SAGA raster tool is used

You can test with this input

https://cld.pt/dl/download/6ac21f8c-0244-45a5-823e-6047bb99b208/bacias_lee_2014_2018_17_Binary.tif

and this command

saga_cmd io_gdal 0 -TRANSFORM 1 -RESAMPLING 0 -GRIDS "imported_raster.sgrd" -FILES "bacias_lee_2014_2018_17_Binary.tif" to This is a really weird issue. This ticket is meant to replace #24317 for sake of clarity.

This only affects Windows.

  1. In OSGeo4w installer the option for SAGA LTR says "2.3.1", but once installed "saga_cmd" says 2.3.2, which is weird per se as SAGA 2.3.2 does not exist:

https://sourceforge.net/projects/saga-gis/files/SAGA%20-%202.3/

  1. if launching SAGA GUI of this SAGA installation it apparently seems all ok, but for instance it misses the "Import > GDAL/OGR" tools which are available in any older and newer (or even the same) versions downloaded from SAGA site. This could be related to the next point, that is the more important

  2. In this OSGEo4W SAGA LTR install the raster import operation (done with the "io_gdal" module) produces a WRONG raster, where 1 are replaced with NULLs. This DOES NOT happen in any older and newer (or even the same) versions downloaded from SAGA site. This is of course a deal breaker for Processing because it calls io_gdal any time a SAGA raster tool is used

You can test with this input

https://cld.pt/dl/download/6ac21f8c-0244-45a5-823e-6047bb99b208/bacias_lee_2014_2018_17_Binary.tif

and this command

saga_cmd io_gdal 0 -TRANSFORM 1 -RESAMPLING 0 -GRIDS "imported_raster.sgrd" -FILES "bacias_lee_2014_2018_17_Binary.tif"

  • version was changed from 2.18.5 to 2.18.7

@qgib
Copy link
Contributor Author

qgib commented May 19, 2017

Author Name: Jürgen Fischer (@jef-n)


@qgib
Copy link
Contributor Author

qgib commented May 29, 2017

Author Name: Pedro Venâncio (Pedro Venâncio)


I think this is fixed now, with saga-ltr-2.3.2-1 shipped with OSGeo4W.

https://trac.osgeo.org/osgeo4w/ticket/527

@qgib
Copy link
Contributor Author

qgib commented May 29, 2017

Author Name: Jürgen Fischer (@jef-n)


  • status_id was changed from Open to Closed

@qgib qgib closed this as completed May 29, 2017
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Build/Install Related to compiling or installing QGIS Regression Something which used to work, but doesn't anymore labels May 25, 2019
@qgib qgib added this to the Version 2.18 milestone May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Build/Install Related to compiling or installing QGIS High Priority Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant