regression: re-loading a project within the same session fails, removes all layers

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)
Original Redmine Issue: 16560
Affected QGIS version: master
Redmine category:project_loading/saving

---

This regression occured within the last 24 hours (May 16-17, 2017). Re-loading a project (or loading a different project which shares same data sources as a currently opened project) within a same QGIS session fails to load layers, resulting in partial to totally blank project.

Steps to reproduce

1. Open QGIS
2. Load a project
3. Without closing QGIS, re-load the same project
4. Notice the absence of any layer, and the blank canvas :)

---

• regression.mp4 (Mathieu Pellerin - nIRV)

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Closing, issue appears to either be localized, or not at all linked to the last 24-hour changes. I'll re-open if I figure out what's happening here.

---

• status_id was changed from Open to Closed

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Re-opening, Matthias has been able to replicate regression.

I've made a small video showing the issue: https://www.youtube.com/watch?v=6freJLe06fk

---

• status_id was changed from Closed to Reopened

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Youtube decided the video was violating its community guidelines. Adding video as an attached mp4 here.

---

• 10968 was configured as regression.mp4

---

• regression.mp4 (Mathieu Pellerin - nIRV)

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Note: my initial estimated time of regression is wrong; I haven't been able to dissect a commit, but problem did emerge earlier than May 16.

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

git bisect spoke out:

fe677040f8c31d4f6fb73489d7fec531166293e3 is the first bad commit
commit fe677040f8c31d4f6fb73489d7fec531166293e3
Author: Nyall Dawson <nyall.dawson@gmail.com>
Date:   Fri May 5 21:27:37 2017 +1000

    Cleanup project closing
    
    - ensure that layers are removed when clearing projects
    - ensure that project is cleared before destruction

[qgib]

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)

---

Applied in changeset 77cd7af.

---

• done_ratio was changed from 0 to 100
• status_id was changed from Reopened to Closed