Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapping allows to snap non displayed legend classes #24737

Closed
qgib opened this issue Jul 10, 2017 · 8 comments
Closed

snapping allows to snap non displayed legend classes #24737

qgib opened this issue Jul 10, 2017 · 8 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality

Comments

@qgib
Copy link
Contributor

qgib commented Jul 10, 2017

Author Name: Regis Haubourg (@haubourg)
Original Redmine Issue: 16838
Affected QGIS version: 3.0.0
Redmine category:digitising
Assignee: Martin Dobias


When unchecking visibility of some classes for categorized or rule based renderer, snapping is still possible even though those features are not visible on map canvas.
This is annoying for some users playing a lot with classes visibility.

Thinking of it, fixing it might not be so direct, as it will imply rebuilding the snapping cache a lot more often.
And currently, it is also possible to keep snapping on an unchecked layer if it is still checked in snapping advanced dock.

Any opinion here?

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2017

Author Name: Regis Haubourg (@haubourg)


  • subject was changed from snapping allons to snap non displayed legend classes to snapping allows to snap non displayed legend classes

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2017

Author Name: Martin Dobias (@wonder-sk)


Fixing that may not require rebuilding of snapping index - snapping classes allow use of custom filters, so one could create a filter that would skip any matches that belong to invisible features...

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2017

Author Name: Regis Haubourg (@haubourg)


Good news!

Do you think that could be considered as a bugfix for backporting to 2.18 ?

@qgib
Copy link
Contributor Author

qgib commented Jul 10, 2017

Author Name: Martin Dobias (@wonder-sk)


Not really, I think the amount of required changes would be larger than what can be still considered as a bug fix safe for backporting...

@qgib
Copy link
Contributor Author

qgib commented Mar 15, 2018

Author Name: Regis Haubourg (@haubourg)


Work will start soon on that. Thanks a lot to the funder!


  • assigned_to_id was configured as Martin Dobias
  • version was changed from 2.18.10 to 3.0.0

@qgib
Copy link
Contributor Author

qgib commented Mar 21, 2018

Author Name: Luigi Pirelli (@luipir)


I can't talk from a user point of view, but I feel that snapping should't be related with the fact that the layer is rendered or not (you may thing to snapToGrid, where grid is not a layer and nor is rendered).
If, from the usability point of view, this is the expected behaviour, I would expect that it would be configurable.
IMHO it's not a bug, but a feature.

@qgib
Copy link
Contributor Author

qgib commented Jun 5, 2018

Author Name: Loïc BARTOLETTI (@lbartoletti)


Done in master #6750

@qgib
Copy link
Contributor Author

qgib commented Jun 5, 2018

Author Name: Regis Haubourg (@haubourg)


  • resolution was changed from to fixed/implemented
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Jun 5, 2018
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Projects
None yet
Development

No branches or pull requests

1 participant