Deleting QGIS bookmarks may leave blank rows or appear to have not deleted a bookmark

[qgib]

Author Name: Steven Mizuno (Steven Mizuno)
Original Redmine Issue: 16990
Affected QGIS version: master
Redmine category:gui
Assignee: Alessandro Pasotti

---

If deleting 2 bookmarks in one operation, one (the second one) is not deleted (confirmed by inspecting tbl_bookmarks).

How to show this:
Add 2 new bookmarks (may need to restart QGIS to see them).
Then select both added bookmarks and delete them. One of the new bookmarks may still be shown and there is a blank row.

Deleting project bookmarks works OK. The list is refreshed and the bookmarks are deleted from the project (confirmed by saving the project, then loading it again).

This is a regression from 2.18.

I am using OSGeo4W nightly build on Windows 8.1 64-bit system.

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Fixed with #5765

---

• resolution was changed from to fixed/implemented
• assigned_to_id was configured as Alessandro Pasotti
• status_id was changed from Open to Closed

[qgib]

Author Name: Steven Mizuno (Steven Mizuno)

---

Reopened because deleting bookmarks still isn't working correctly with master (010cb15).

After recent fixes to spatial bookmarks, deleting selected bookmarks may remove bookmarks that weren't selected and not remove those that were selected -- I believe it depends on the sort order.

And the list also is not properly refreshed when deleting bookmarks.

---

• status_id was changed from Closed to Reopened

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Thanks for the feedback, I've made a PR with the fixes, #5852

I'd appreciate if you could test them when committed.

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

• status_id was changed from Reopened to Closed