Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: cannot save updates in csv file opened as OGR vector layer #25421

Closed
qgib opened this issue Nov 22, 2017 · 13 comments
Closed

Windows: cannot save updates in csv file opened as OGR vector layer #25421

qgib opened this issue Nov 22, 2017 · 13 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Vectors Related to general vector layer handling (not specific data formats)

Comments

@qgib
Copy link
Contributor

qgib commented Nov 22, 2017

Author Name: Olga Grabek (Olga Grabek)
Original Redmine Issue: 17524
Affected QGIS version: master
Redmine category:vectors


Steps to reproduce:

  1. Choose Add vector layer option
  2. Load attached csv file
  3. When file is loaded as a layer, choose Open Attribute Table
  4. Choose Toggle editing mode
  5. Choose Save Edits

The error is thrown: "OGR error syncing to disk: Cannot rename files"

It seems to be problem only on Windows (tested on two devices with Windows 10). On Mac everything seems to be working.


@qgib
Copy link
Contributor Author

qgib commented Nov 24, 2017

Author Name: Giovanni Manghi (@gioman)


Please update to 2.18.14 (the new LTR release) and try again. Thanks!


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Nov 26, 2017

Author Name: Olga Grabek (Olga Grabek)


Unfortunately, the issue still exists in 2.18.14. When I change any attribute in the _ Attribute Table_ and click Save Edits I get this error. The same issue is also when I try to add a new feature to the layer. I can only remove features from layer without errors from OGR.

I'm not sure this is helpful but when I opened Log Messages Panel OGR reports:

Unbalanced call to leaveUpdateMode() w.r.t. enterUpdateMode()


  • assigned_to_id was configured as Giovanni Allegri

@qgib
Copy link
Contributor Author

qgib commented Nov 26, 2017

Author Name: Giovanni Manghi (@gioman)


Cannot replicate here with the data you provided.


  • assigned_to_id removed Giovanni Allegri

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Olga Grabek (Olga Grabek)


Giovanni Manghi wrote:

Cannot replicate here with the data you provided

Thanks for a response. Did you try to reproduce it on a Window's machine ? This is strange that you can't reproduce it, as we are getting the same error on four different machines with Windows OS (2xWindows 10, 1xWindows 7 and 1xWindows Server). Be aware that the error is thrown when you change any attribute in Attribute table and then try to SAVE changes.

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Olga Grabek (Olga Grabek)


  • assigned_to_id was configured as Giovanni Manghi

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Giovanni Manghi (@gioman)


Olga Grabek wrote:

Be aware that the error is thrown when you change any attribute in Attribute table and then try to SAVE changes.

this means adding/deleting/editing a column or changing its content?

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Giovanni Manghi (@gioman)


  • assigned_to_id removed Giovanni Manghi

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Olga Grabek (Olga Grabek)


It means changing a content in any column.

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Richard Duivenvoorde (@rduivenvoorde)


Confirmed here with 2.18.4 AND master on Windows10.

As said: on Linux it is not a problem, it just works.

Seems an OGR - Windows problem (when opening with as txt delimited file, editing is not possible)


  • subject was changed from Cannot save updates in csv file openned as vactor layer to Cannot save updates in csv file opened as OGR vector layer

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Giovanni Manghi (@gioman)


Seems an OGR - Windows problem (when opening with as txt delimited file, editing is not possible)

correct, it is problem on Windows. If the CSV is added as vector is editable but on save the reported error is thrown. To add insult to injury if the table covers the message bar the user don't see the error and when toggling editing the unsaved values are sticking in the table giving the sensation that edits went well...

Confirmed also on master.


  • subject was changed from Cannot save updates in csv file opened as OGR vector layer to Windows: cannot save updates in csv file opened as OGR vector layer
  • status_id was changed from Feedback to Open
  • version was changed from 2.14.14 to master
  • operating_system was changed from Windows 10 to Windows

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Giovanni Manghi (@gioman)


  • category_id was changed from Attribute table to Vectors

@qgib
Copy link
Contributor Author

qgib commented Mar 9, 2019

Author Name: Giovanni Manghi (@gioman)


Please check if this issue is still valid on QGIS 3.4.5 or 3.6.


  • status_id was changed from Open to Feedback

@qgib qgib added Feedback Waiting on the submitter for answers Bug Either a bug report, or a bug fix. Let's hope for the latter! Vectors Related to general vector layer handling (not specific data formats) labels May 25, 2019
@gioman
Copy link
Contributor

gioman commented Mar 26, 2020

Duplicate of #35144

@gioman gioman marked this as a duplicate of #35144 Mar 26, 2020
@gioman gioman closed this as completed Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers Vectors Related to general vector layer handling (not specific data formats)
Projects
None yet
Development

No branches or pull requests

2 participants