Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i"nstall plugin from zip" stopped to work on Windows #25521

Closed
qgib opened this issue Dec 4, 2017 · 13 comments
Closed

i"nstall plugin from zip" stopped to work on Windows #25521

qgib opened this issue Dec 4, 2017 · 13 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Plugins Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Dec 4, 2017

Author Name: Tom Chadwin (@tomchadwin)
Original Redmine Issue: 17624
Affected QGIS version: master
Redmine category:plugin_manager
Assignee: Borys Jurgiel


Open plugin manager

  1. Install from ZIP
  2. Browse to plugin zipfile
  3. Install plugin

I get:

An error occurred during execution of following code:
pyplugin_installer.instance().installFromZipFile('C:\Users\tchadwin\Downloads\qgis-latlontools-plugin.zip')


  File "", line 1
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 2-3: truncated \UXXXXXXXX escape


Python version:
3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)]

QGIS version:
2.99.0-Master 'Master', 57dc9deb06

Python path:
['C:/OSGEO4~1/apps/qgis-dev/./python/plugins\\processing', 'C:/OSGEO4~1/apps/qgis-dev/./python', 'C:/Users/tchadwin/AppData/Roaming/QGIS/QGIS3\\profiles\\default/python', 'C:/Users/tchadwin/AppData/Roaming/QGIS/QGIS3\\profiles\\default/python/plugins', 'C:/OSGEO4~1/apps/qgis-dev/./python/plugins', 'C:\\OSGeo4W64\\bin\\python36.zip', 'C:\\OSGEO4~1\\apps\\Python36\\DLLs', 'C:\\OSGEO4~1\\apps\\Python36\\lib', 'C:\\OSGeo4W64\\bin', 'C:\\OSGEO4~1\\apps\\Python36', 'C:\\OSGEO4~1\\apps\\Python36\\lib\\site-packages', 'C:/Users/tchadwin/AppData/Roaming/QGIS/QGIS3\\profiles\\default/python', 'C:/Users/tchadwin/Desktop']

Tested on qgis2web (Github master) and LatLong Tools (Github master)

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Tom Chadwin (@tomchadwin)


Tested against QGIS 57dc9de

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


It works with other plugins, so seems something specific to the plugins you tested.


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Tom Chadwin (@tomchadwin)


If you can upload a known working zip (or link to one), I can test that.

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


Tom Chadwin wrote:

If you can upload a known working zip (or link to one), I can test that.

this
https://github.com/enricofer/go2mapillary/archive/master.zip

worked here on master/ubuntu.

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Tom Chadwin (@tomchadwin)


Same result with that zip:

An error occurred during execution of following code:
pyplugin_installer.instance().installFromZipFile('C:\Users\tchadwin\Downloads\go2mapillary-master.zip')


  File "", line 1
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 2-3: truncated \UXXXXXXXX escape


Python version:
3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 08:06:12) [MSC v.1900 64 bit (AMD64)]

QGIS version:
2.99.0-Master 'Master', 57dc9deb06

Python path:
['C:/OSGEO4~1/apps/qgis-dev/./python/plugins\\processing', 'C:/OSGEO4~1/apps/qgis-dev/./python', 'C:/Users/tchadwin/AppData/Roaming/QGIS/QGIS3\\profiles\\default/python', 'C:/Users/tchadwin/AppData/Roaming/QGIS/QGIS3\\profiles\\default/python/plugins', 'C:/OSGEO4~1/apps/qgis-dev/./python/plugins', 'C:\\OSGeo4W64\\bin\\python36.zip', 'C:\\OSGEO4~1\\apps\\Python36\\DLLs', 'C:\\OSGEO4~1\\apps\\Python36\\lib', 'C:\\OSGeo4W64\\bin', 'C:\\OSGEO4~1\\apps\\Python36', 'C:\\OSGEO4~1\\apps\\Python36\\lib\\site-packages', 'C:/Users/tchadwin/AppData/Roaming/QGIS/QGIS3\\profiles\\default/python', 'C:/Users/tchadwin/Desktop']

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Borys Jurgiel (@borysiasty)


Giovanni, I'm pretty sure it's windows (backslash) thing.

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to High
  • regression was changed from 0 to 1
  • operating_system was changed from Windows 7 x64 to Windows
  • status_id was changed from Feedback to Open
  • subject was changed from Cannot install plugin from zip file to i"nstall plugin from zip" stopped to work on Windows

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Borys Jurgiel (@borysiasty)


Applied in changeset f180ea4.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Dec 4, 2017
@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to fixed/implemented

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Borys Jurgiel (@borysiasty)


Tom, could you please verify it tomorrow with the real build and reopen if necessary? I did some dummy tests and I believe it will work.

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Tom Chadwin (@tomchadwin)


Will do. Thanks!

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Borys Jurgiel (@borysiasty)


For now, you can install from other directories - just avoid the "\U" special character (like in "C:\Users").

Ah, and when investigating the issue, I found a few other bugs and created #25523 . It seems the newly installed plugin is not included to the installed plugins list, so you can't tick the checkbox to enable it (btw. the fastest way to refresh the list is the Settings tab -> "Reload all repositories"). Feel free to add more annoying bugs there - I'm going to get down to it in a few days.

@qgib
Copy link
Contributor Author

qgib commented Dec 5, 2017

Author Name: Tom Chadwin (@tomchadwin)


Fix confirmed in 32ba5bf. Thanks very much, everyone!

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Plugins Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Plugins Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant