Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Layers not activating when Theme is selected. #25823

Closed
qgib opened this issue Jan 22, 2018 · 7 comments
Closed

Group Layers not activating when Theme is selected. #25823

qgib opened this issue Jan 22, 2018 · 7 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Jan 22, 2018

Author Name: Nathan Saylor (@gisn8)
Original Redmine Issue: 17927
Affected QGIS version: master
Redmine category:gui
Assignee: Alessandro Pasotti


Even when the group layer is turned on when saving a theme, it does not come on when the theme is activated, thus keeping desired layers hidden.

@qgib
Copy link
Contributor Author

qgib commented Jan 22, 2018

Author Name: Nathan Saylor (@gisn8)


Playing around a little more with it,starting with a new project...

  1. Add two layers
  2. Add group layer
  3. Move the two layers to the group layer.
  4. With all three activated, add Theme.
  5. Add another layer; move it out of the group if necessary.
  6. Turn off group layer.
  7. Click on Theme to activate.
    7r. Group layer does not activate. Theme shows active.
  8. Turn on group layer to reveal layers.
    8r. Theme shows inactive.
  9. Turn off layers inside group.
    9r. THEME SHOWS ACTIVE?!
  10. With the sublayers already off, turn off group layer.
    10r. Theme still shows active!

@qgib
Copy link
Contributor Author

qgib commented Jan 24, 2018

Author Name: Alessandro Pasotti (@elpaso)


  • assigned_to_id was configured as Alessandro Pasotti

@qgib
Copy link
Contributor Author

qgib commented Jan 24, 2018

Author Name: Alessandro Pasotti (@elpaso)


Do I understand that correctly that the issue is that if the layers in a theme are within a group the group must be switched on if at least one of the layers is visible?

Let's make an example V=visible v=visible-grey:

[V] Group 1
    [V] Layer 1
    [V] Layer 2
-> save theme
-> make some changes in the tree
[ ] Group 1
    [v] Layer 1
    [ ] Layer 2
-> activate theme
[V] Group 1
    [V] Layer 1
    [V] Layer 2
-> make some changes in the tree
[V] Group 1
    [V] Layer 1
    [ ] Layer 2
-> activate theme
[V] Group 1
    [V] Layer 1
    [V] Layer 2


If this is the issue, a patch is coming ...

Note that group status is not saved in the themes.

@qgib
Copy link
Contributor Author

qgib commented Jan 24, 2018

Author Name: Alessandro Pasotti (@elpaso)


PR: #6163


  • pull_request_patch_supplied was changed from 0 to 1
  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Jan 24, 2018

Author Name: Nathan Saylor (@gisn8)


The group layers have always responded to the the toggling of any of its sublayers. THAT may actually be the bigger issue here. So yeah, I think you got it then. I didn't realize that the problem isn't with the Themes, but with how the groups and sublayers are responding to each other. Thanks!

@qgib
Copy link
Contributor Author

qgib commented Jan 25, 2018

Author Name: Anónimo (Anónimo)


Applied in changeset b644447.


  • done_ratio was changed from 0 to 100
  • status_id was changed from In Progress to Closed

@qgib qgib closed this as completed Jan 25, 2018
@qgib
Copy link
Contributor Author

qgib commented Jan 25, 2018

Author Name: Alessandro Pasotti (@elpaso)


Please give it a try.


  • resolution was changed from to fixed/implemented

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant