Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWG import overwrites existing Geopackage without warning #27382

Closed
qgib opened this issue Aug 7, 2018 · 3 comments
Closed

DWG import overwrites existing Geopackage without warning #27382

qgib opened this issue Aug 7, 2018 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting

Comments

@qgib
Copy link
Contributor

qgib commented Aug 7, 2018

Author Name: Micha Silver (@micha-silver)
Original Redmine Issue: 19555
Affected QGIS version: 3.2.1
Redmine category:dwg/dxf_import
Assignee: Jürgen Fischer


The DWG import function to reads a DWG/DXF file and imports into a Geopackage file. If an existing gpkg file is chosen, it is silently overwritten. A warning should be issued.

Furthermore, when opening the "DWG Import" dialog, the previously used gpkg file persists in the Geopackage textbox, so the danger of accidentally overwriting is increased. That dialog should be initialized with all textboxes empty by default.

@qgib
Copy link
Contributor Author

qgib commented Sep 26, 2018

Author Name: Jürgen Fischer (@jef-n)


Why is that dangerous? You can always reimport the original DWG.

@qgib
Copy link
Contributor Author

qgib commented Sep 27, 2018

Author Name: Micha Silver (@micha-silver)


For two reasons:

  1. In QGIS (and most applications) a user never expects her files to be overwritten without a warning, and a chance to OK/Cancel.
  2. If I import a second DWG file, it's very easy to overlook the file name from the first DWG that persists in the "Geopackage" text box, and then overwrite that earlier gpkg by accident.

I think that the expected behavior should be: the Geopackage text box should be empty with each invocation of the DWG/DXF Import dialogue, and always issue a warning when overwriting.

THanks

@qgib
Copy link
Contributor Author

qgib commented Oct 9, 2018

Author Name: Anónimo (Anónimo)


Applied in changeset b74292a.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Oct 9, 2018
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting
Projects
None yet
Development

No branches or pull requests

1 participant