Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm shortcuts in Vector & Raster menus shouldn't be capitalized in most languages #27549

Closed
qgib opened this issue Aug 28, 2018 · 9 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Aug 28, 2018

Author Name: Borys Jurgiel (@borysiasty)
Original Redmine Issue: 19724
Affected QGIS version: 3.3(master)
Redmine category:processing/gui
Assignee: Nyall Dawson


These Processing shortcuts are now capitalised after being translated.

In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian.

So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user).

I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to MixedCase if the current language is not "capitalistic" ;)


@qgib
Copy link
Contributor Author

qgib commented Aug 28, 2018

Author Name: Borys Jurgiel (@borysiasty)


  • 13208 was configured as Screenshot_20180828_114117.png

@qgib
Copy link
Contributor Author

qgib commented Aug 28, 2018

Author Name: Harrissou Santanna (@DelazJ)


Thanks for raising this, Borys.
I guess your issue also concerns Processing dialog titles being capitalized when run from these shortcuts or the toolbox (but not from the modeller btw).


  • subject was changed from Algorithm shortcuts in Vector & Raster menus shouldn't by capitalized in most languages to Algorithm shortcuts in Vector & Raster menus shouldn't be capitalized in most languages

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Harrissou Santanna (@DelazJ)


Hi, May I ask if there's any progress on this?
If using title case for dialogs seems to make dialogs look pretty in English, in French (in my case), it's really ugly and against HIG. Same for menu items.
Would be nice if this can be fixed before the release (I get complaints from users that do not understand why the GUI does not reflect their translations).
Thanks.


  • version was changed from 3.2 to 3.3(master)

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Borys Jurgiel (@borysiasty)


  • description was changed from These Processing shortcuts are now capitalised after being translated.

In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian.

So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user).

I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to ForceFirstLetterToCapital if the current language is not "capitalistic" ;)

to These Processing shortcuts are now capitalised after being translated.

In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian.

So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user).

I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to MixedCase if the current language is not "capitalistic" ;)

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Borys Jurgiel (@borysiasty)


I'm just fixing it.

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Borys Jurgiel (@borysiasty)


  • pull_request_patch_supplied was changed from 0 to 1

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Borys Jurgiel (@borysiasty)


See #8269

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Harrissou Santanna (@DelazJ)


Thank you very much, Borys.

@qgib
Copy link
Contributor Author

qgib commented Oct 25, 2018

Author Name: Borys Jurgiel (@borysiasty)


Applied in changeset d0813a8.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Oct 25, 2018
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant