-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Algorithm shortcuts in Vector & Raster menus shouldn't be capitalized in most languages #27549
Comments
Author Name: Borys Jurgiel (@borysiasty)
|
Author Name: Harrissou Santanna (@DelazJ) Thanks for raising this, Borys.
|
Author Name: Harrissou Santanna (@DelazJ) Hi, May I ask if there's any progress on this?
|
Author Name: Borys Jurgiel (@borysiasty)
In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian. So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user). I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to ForceFirstLetterToCapital if the current language is not "capitalistic" ;) to These Processing shortcuts are now capitalised after being translated. In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian. So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user). I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to MixedCase if the current language is not "capitalistic" ;) |
Author Name: Borys Jurgiel (@borysiasty) I'm just fixing it. |
Author Name: Borys Jurgiel (@borysiasty)
|
Author Name: Borys Jurgiel (@borysiasty) See #8269 |
Author Name: Harrissou Santanna (@DelazJ) Thank you very much, Borys. |
Author Name: Borys Jurgiel (@borysiasty) Applied in changeset d0813a8.
|
Author Name: Borys Jurgiel (@borysiasty)
Original Redmine Issue: 19724
Affected QGIS version: 3.3(master)
Redmine category:processing/gui
Assignee: Nyall Dawson
These Processing shortcuts are now capitalised after being translated.
In most languages menus (and generally titles) are not supposed to be capitalised. I can speak for Slavic languages where it looks really oddly, but I believe it's quite the same in most European languages, including German, French, Spain, Italian etc. Looking through our i18n, I've only found capitalized menus in Portuguese Portuguese (unlike Brasilian Portuguese) and somehow partially in Romanian.
So I'd perform the capitalization only if the system locale is on a white list (or rather the GUI language, as it can be overwritten by user).
I'm not sure if it should be a local change in python/plugins/processing/gui/menus.py, or just the QgsStringUtils::capitalize() should always fallback TitleCase to MixedCase if the current language is not "capitalistic" ;)
The text was updated successfully, but these errors were encountered: