Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS Server 3 / WMS: the SLD parameter support has been removed #27620

Closed
qgib opened this issue Sep 7, 2018 · 10 comments
Closed

QGIS Server 3 / WMS: the SLD parameter support has been removed #27620

qgib opened this issue Sep 7, 2018 · 10 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore Server Related to QGIS server

Comments

@qgib
Copy link
Contributor

qgib commented Sep 7, 2018

Author Name: René-Luc ReLuc (@rldhont)
Original Redmine Issue: 19795
Affected QGIS version: 3.0.0
Redmine category:qgis_server


With the suppression of the class QgsHttpTransaction, the support of SLD parameter has been removed.

Here is the code:

  // SLD
  QString value = parameters.value( QStringLiteral( "SLD" ) );
  if ( !value.isEmpty() )
  {
    QgsMessageLog::logMessage( QStringLiteral( "http and ftp methods not supported with Qt5." ) );
  }

@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2018

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to High

@qgib
Copy link
Contributor Author

qgib commented Sep 11, 2018

Author Name: Tudor Bărăscu (@tudorbarascu)


Also, the stroke width functions don't function for points and linestrings (only for polygon) although the request goes ok to the server.

You can also replicate under Desktop by:

  • export a point sld file with a specific stroke-width (30 pixels for example)
  • looking at the sld file the stroke width gets exported
<se:SvgParameter name="stroke-width">30</se:SvgParameter>

  • importing the sld file ignores the stroke-width to the default (PROBLEM)

@qgib
Copy link
Contributor Author

qgib commented Sep 11, 2018

Author Name: René-Luc ReLuc (@rldhont)


PR supplied: #7859


  • pull_request_patch_supplied was changed from 0 to 1

@qgib
Copy link
Contributor Author

qgib commented Sep 11, 2018

Author Name: René-Luc ReLuc (@rldhont)


Hi Tudor Bărăscu,

Is there an open issue for your comment ?
Is there some tests in QGIS about SLD support ?

@qgib
Copy link
Contributor Author

qgib commented Sep 16, 2018

Author Name: Alessandro Pasotti (@elpaso)


  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Sep 18, 2018

Author Name: Tudor Bărăscu (@tudorbarascu)


Hi René,

Somehow I didn't notice your reply.
Couldn't find any tests or any open issue regarding this.
The server tests are relatively easy to write.. but I cannot add the exact output image as the stroke-width is ignored and I don't know how to capture the exact image (I haven't tried) from Desktop.

I'll try and see if I can output with QGIS Server 2 and create a pull request.

All the best,
Tudor

@qgib
Copy link
Contributor Author

qgib commented Sep 20, 2018

Author Name: Tudor Bărăscu (@tudorbarascu)


Pull request with SLD import fix + test at #7961
The server now outputs correctly for Point and Polygon but for line SLD's it outputs nothing.
I'll try and replicate in a test with the help of the 2.18 server.

@qgib
Copy link
Contributor Author

qgib commented Jan 25, 2019

Author Name: Alessandro Pasotti (@elpaso)


What's the situation with current master?

@qgib
Copy link
Contributor Author

qgib commented Jan 25, 2019

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from In Progress to Feedback

@qgib
Copy link
Contributor Author

qgib commented Mar 9, 2019

Author Name: Giovanni Manghi (@gioman)


Tudor Bărăscu wrote:

Pull request with SLD import fix + test at #7961

this is merged and therefore I assume is fixed, please reopen if necessary.


  • resolution was changed from to fixed/implemented
  • status_id was changed from Feedback to Closed

@qgib qgib closed this as completed Mar 9, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Server Related to QGIS server Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Regression Something which used to work, but doesn't anymore Server Related to QGIS server
Projects
None yet
Development

No branches or pull requests

1 participant