Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check geometries crashing QGIS 3.6 #29435

Closed
qgib opened this issue Mar 19, 2019 · 11 comments
Closed

Check geometries crashing QGIS 3.6 #29435

qgib opened this issue Mar 19, 2019 · 11 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Feedback Waiting on the submitter for answers High Priority Plugins

Comments

@qgib
Copy link
Contributor

qgib commented Mar 19, 2019

Author Name: Pedro Henrique Caldeira Caliari (Pedro Henrique Caldeira Caliari)
Original Redmine Issue: 21619
Affected QGIS version: 3.6.0
Redmine category:c++_plugins/geometry_checker


After running Check Geometries on QGIS 3.6, even by selecting a single vector layer or some of it's features, QGIS is crashing. When it has a considerable amount of errors, a "QGIS has crashed" window appears, while with a "small" amount of errors (230 or so), the algorithm might run normally and then QGIS crashes in less than a minute. Could it be that I'm using layers and files from a QGIS 2.x material? (if I run on all the layers, about 30k errors are reported and 350k+ errors are given as fixed/processed)

If Check Geometries shouldn't be used for layers containing many errors, which tool should I use in it's place for fixing common geometry errors?


  • Roads.7z (Pedro Henrique Caldeira Caliari)
@qgib
Copy link
Contributor Author

qgib commented Mar 20, 2019

Author Name: Giovanni Manghi (@gioman)


Please attach sample data and the exact specific configurations you are using in the geometry checker.


  • category_id was changed from Geometry to C++ plugins/Geometry Checker
  • status_id was changed from Open to Feedback
  • priority_id was changed from Normal to High

@qgib
Copy link
Contributor Author

qgib commented Mar 20, 2019

Author Name: Pedro Henrique Caldeira Caliari (Pedro Henrique Caldeira Caliari)


Giovanni Manghi wrote:

Please attach sample data and the exact specific configurations you are using in the geometry checker.

Input vector layers: only the attached layer.
Allowed geometries: line, multiline;
Geometry validity : duplicate nodes;
Geometry properties: none;
Geometry conditions: none;
Topology checks: check for duplicates;
Tolerance: 1e-6
Output: ESRI shapefile on temp directory


  • 14649 was configured as Roads.7z

  • Roads.7z (Pedro Henrique Caldeira Caliari) - 7zip with the .shp and other layer files.

@qgib
Copy link
Contributor Author

qgib commented Mar 21, 2019

Author Name: Giovanni Manghi (@gioman)


Confirmed here also on Linux.


  • operating_system was changed from Windows 10 to
  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Mar 28, 2019

Author Name: Giovanni Zanoni (Giovanni Zanoni)


I am getting the same issue with QGIS 3.6 (and 3.4) even with a clean profile. It's ok in QGIS 3.2

@qgib
Copy link
Contributor Author

qgib commented Mar 28, 2019

Author Name: Alessandro Pasotti (@elpaso)


  • assigned_to_id was configured as Alessandro Pasotti

@qgib
Copy link
Contributor Author

qgib commented Mar 29, 2019

Author Name: Alessandro Pasotti (@elpaso)


I cannot reproduce with test data on master/Linux Ubuntu 18.10


  • assigned_to_id removed Alessandro Pasotti

@qgib
Copy link
Contributor Author

qgib commented Apr 2, 2019

Author Name: Giovanni Zanoni (Giovanni Zanoni)


Fresh installation (3.6.1) but no way out (ok in 3.2). Check geometry plugin (with quite big dataset) makes QGis crash on Windows 10

@qgib
Copy link
Contributor Author

qgib commented Apr 2, 2019

Author Name: Giovanni Manghi (@gioman)


No more problems, with the provided dataset, here now on 3.6.1 on linux.


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Apr 2, 2019

Author Name: Giovanni Manghi (@gioman)


Giovanni Manghi wrote:

No more problems, with the provided dataset, here now on 3.6.1 on linux.

spoke too soon: it still crashes. It does when clicking on "ok" after the tool has fixed all the errors found.

does the same happens on 2.18? can anyone test?

@qgib qgib added Feedback Waiting on the submitter for answers Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Plugins Crash/Data Corruption labels May 25, 2019
@gioman gioman removed the Feedback Waiting on the submitter for answers label Aug 25, 2019
@lbartoletti
Copy link
Member

I cannot reproduce with QGIS 3.16 with the data. @gioman Do you reproduce the crash?

@lbartoletti lbartoletti added the Feedback Waiting on the submitter for answers label Feb 9, 2021
@gioman
Copy link
Contributor

gioman commented Feb 9, 2021

I cannot reproduce with QGIS 3.16 with the data. @gioman Do you reproduce the crash?

@lbartoletti no more crashes, please reopen if necessary.

@gioman gioman closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption Feedback Waiting on the submitter for answers High Priority Plugins
Projects
None yet
Development

No branches or pull requests

3 participants