Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] fix identify panel size when long localized strings used (fix #29546) #33643

Merged
merged 2 commits into from
Jan 9, 2020
Merged

[GUI] fix identify panel size when long localized strings used (fix #29546) #33643

merged 2 commits into from
Jan 9, 2020

Conversation

alexbruy
Copy link
Contributor

@alexbruy alexbruy commented Jan 7, 2020

Description

In some locales "Auto open form" text and some items in the "Mode" combobox in the identify panel translated as very long strings. As result panel takes too much screen space and can not be reduced.

Proposed PR replaces QCheckBox with QCheckBox and QLabel with enabled word-wrapping and changes width of the "Mode" combobox. Fixes #29546.

Before
no-wrap
After
wrap

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

@alexbruy alexbruy added backport release-3_10 GUI/UX Related to QGIS application GUI or User Experience labels Jan 8, 2020
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge.

@alexbruy alexbruy merged commit 7240052 into qgis:master Jan 9, 2020
@qgis-bot
Copy link
Collaborator

qgis-bot commented Jan 9, 2020

The backport to release-3_10 failed:

The process 'git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-33643-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 72400524f72e6d83a18a86344cf6c72a886b798f
# Push it to GitHub
git push --set-upstream origin backport-33643-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10

Then, create a pull request where the base branch is release-3_10 and the compare/head branch is backport-33643-to-release-3_10.

@alexbruy alexbruy deleted the identify-word-wrap branch January 9, 2020 07:58
nirvn added a commit to nirvn/QGIS that referenced this pull request Jan 10, 2020
…en action

(this is a follow up to PR qgis#33643) better combobox / checkbox placement
nirvn added a commit that referenced this pull request Jan 10, 2020
…en action

(this is a follow up to PR #33643) better combobox / checkbox placement
nirvn added a commit to nirvn/QGIS that referenced this pull request Jan 10, 2020
…en action

(this is a follow up to PR qgis#33643) better combobox / checkbox placement
nyalldawson pushed a commit that referenced this pull request Jan 10, 2020
…en action

(this is a follow up to PR #33643) better combobox / checkbox placement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed minimum width of Identify Results Dialog
3 participants