-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GUI] fix identify panel size when long localized strings used (fix #29546) #33643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the identify panel (fix #29546)
nirvn
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to merge.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_10 release-3_10
# Navigate to the new working tree
cd .worktrees/backport-release-3_10
# Create a new branch
git switch --create backport-33643-to-release-3_10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 72400524f72e6d83a18a86344cf6c72a886b798f
# Push it to GitHub
git push --set-upstream origin backport-33643-to-release-3_10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_10 Then, create a pull request where the |
6 tasks
nirvn
added a commit
to nirvn/QGIS
that referenced
this pull request
Jan 10, 2020
…en action (this is a follow up to PR qgis#33643) better combobox / checkbox placement
6 tasks
nirvn
added a commit
that referenced
this pull request
Jan 10, 2020
…en action (this is a follow up to PR #33643) better combobox / checkbox placement
nirvn
added a commit
to nirvn/QGIS
that referenced
this pull request
Jan 10, 2020
…en action (this is a follow up to PR qgis#33643) better combobox / checkbox placement
nyalldawson
pushed a commit
that referenced
this pull request
Jan 10, 2020
…en action (this is a follow up to PR #33643) better combobox / checkbox placement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some locales "Auto open form" text and some items in the "Mode" combobox in the identify panel translated as very long strings. As result panel takes too much screen space and can not be reduced.
Proposed PR replaces
QCheckBox
withQCheckBox
andQLabel
with enabled word-wrapping and changes width of the "Mode" combobox. Fixes #29546.Before
![no-wrap](https://user-images.githubusercontent.com/776954/71905422-c8039e80-3170-11ea-810e-b50a787075eb.png)
![wrap](https://user-images.githubusercontent.com/776954/71905432-cc2fbc00-3170-11ea-8f52-1b74654e63ad.png)
After
Checklist
Fixes #11111
at the bottom of the commit messagescripts/prepare-commit.sh
script before each commit