Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[needs-docs][ui] Better placement for the method combobox and auto open action #33704

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jan 10, 2020

Description

@alexbruy , this is a follow up to your PR #33643. I noticed a few UI regressions after the commit was merged:
image

  • the combo box text gets clipped even though there's space for it to display;
  • there's a wider-than-normal space between the checkbox and its label, which if the above-mentioned combo box is expanded ends up being closer to the checkbox than the label is; and
  • clicking on the label doesn't toggle the checkbox, breaking well established UI expectations.

This PR fixes the regressions by removing the spacer and allowing the combo box to expand to fill available space, and moves the auto open form checkbox to a settings menu accessible via the panel toolbar. The latter is a more disrupting change, but IMHO is the right thing to do. It gives us the space to have a more self-explanatory string, works for all locale, and essentially moves a setting that doesn't need to always be part of the panel into a pop up menu.

It looks like that now:
image

Checklist

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include Fixes #11111 at the bottom of the commit message
  • I have read the QGIS Coding Standards and this PR complies with them
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit
  • I have evaluated whether it is appropriate for this PR to be backported, backport requests are left as label or comment

…en action

(this is a follow up to PR qgis#33643) better combobox / checkbox placement
@nirvn nirvn added GUI/UX Related to QGIS application GUI or User Experience Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Jan 10, 2020
@nirvn
Copy link
Contributor Author

nirvn commented Jan 10, 2020

@alexbruy , let me know if you are fine with this alternative solution.

@alexbruy
Copy link
Contributor

@nirvn I'm fine with proposed solution.

Another option, if we want to keep checkbox on the panel, is to implement custom checkbox widget with word-wrapping. I was thinking about it and even made a prototype for it. But after looking in various dialogs seems there are no other places where it can be used, so I decide to took simpler path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants