New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Mesh][3D] new 3D mesh layer renderer #33837
Conversation
Holy heck! Win!
… |
b2faab9
to
23de310
Compare
Looks awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
(Note: I have done a couple of review iterations with Vincent earlier this week and in the current state it is good to get merged for 3.12 in my opinion.)
I looked over the code and couldn't see any issues, but I'm familiar neither with the 3d code nor the mesh provider, so it was only a very general review. If @wonder-sk is happy, then merge away! |
Incredible! |
If there's anything new in the GUI or worth documenting, can someone label this PR appropriately so that we get the PR description in docs repo? The current issue report description is rather... Thanks |
@vcloarec A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
@vcloarec |
@vcloarec A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
@vcloarec |
This PR change the 3D mesh renderer approach
The new approach is based on OpenGL shader. By this way, the GPU handles rendering wireframe and color ramp shading.
There are two entries to render the mesh layer in the 3D view :
The user can choose those settings
For now, the mesh can be rendered as a TIN but rendering dataset is not supported. However the infrastructure is adapted for a future PR.
Fixes #11111
at the bottom of the commit messagescripts/prepare-commit.sh
script before each commit