-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonize 3D map view widget with 2D ones to display the map theme drop-down menu #34369
Conversation
@ismailsunni , I like this a lot, you get my seal of approval UI/UX-wise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great!
With mesh-based terrain, that's a limitation of the mesh terrain generator - hopefully in a future version it will be able to show arbitrary map theme!
@ismailsunni can you fix the conflict here? |
ca54b95
to
8f560fe
Compare
@nyalldawson done, waiting for the checks now |
Please don't merge this PR. After I rebase the code to fix the conflict, it will crash QGIS whenever I open the 3D view. It was fine though before rebasing the code. |
8f560fe
to
cf21a0c
Compare
I fixed the crash issue, and it should be ready to merge if the test pass. |
Description