Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize 3D map view widget with 2D ones to display the map theme drop-down menu #34369

Merged
merged 5 commits into from
Mar 13, 2020

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Feb 8, 2020

Description

@nirvn
Copy link
Contributor

nirvn commented Feb 9, 2020

@ismailsunni , I like this a lot, you get my seal of approval UI/UX-wise.

@ismailsunni
Copy link
Contributor Author

Thanks @nirvn , credit to @DelazJ who gave the idea, I merely put the code :)

@timlinux timlinux added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Feb 13, 2020
Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great!

With mesh-based terrain, that's a limitation of the mesh terrain generator - hopefully in a future version it will be able to show arbitrary map theme!

@nyalldawson
Copy link
Collaborator

@ismailsunni can you fix the conflict here?

@ismailsunni
Copy link
Contributor Author

@nyalldawson done, waiting for the checks now

@ismailsunni
Copy link
Contributor Author

Please don't merge this PR. After I rebase the code to fix the conflict, it will crash QGIS whenever I open the 3D view. It was fine though before rebasing the code.
I will try to check this first.

@ismailsunni
Copy link
Contributor Author

I fixed the crash issue, and it should be ready to merge if the test pass.

@PeterPetrik PeterPetrik merged commit 9e5966c into qgis:master Mar 13, 2020
@timlinux timlinux removed the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonize 3D map view widget with 2D ones to display the map theme drop-down menu
6 participants