[feature] Allow renaming of the current map theme #33950

DelazJ · 2020-01-21T09:52:39Z

This is an early PR to add ability to rename map theme from the map theme drop-down menu (fixes #26563).
I can't say that the code is the cleanest you could have since there are some coding basis I do not have (and I expect it gets improved before merge) but from a user point of view the feature works.

src/core/layout/qgslayoutitemmap.cpp

src/core/qgsmapthemecollection.cpp

src/core/qgsmapthemecollection.h

nyalldawson · 2020-01-21T23:46:03Z

Looking good so far!

nyalldawson · 2020-01-21T23:46:36Z

Personally I'd classify this as a bug fix, and merge for 3.12.

stale · 2020-02-04T23:57:16Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

src/core/qgsmapthemecollection.h

DelazJ · 2020-02-06T06:12:56Z

Thanks for the inputs @nyalldawson

stale · 2020-02-20T09:28:12Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

DelazJ · 2020-02-26T08:14:34Z

Any help here, please? I don't want it to get stale.
That said, I think I can do the 3d part if #34369 is merged (but not sure of the "backportability" at that moment)

stale · 2020-03-18T07:14:14Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

If the applied map theme is being renamed, ensure we do not lose that.

Co-Authored-By: Nyall Dawson <nyall.dawson@gmail.com>

DelazJ · 2020-04-02T06:52:14Z

May I?

src/gui/qgsmapcanvas.h

src/core/layout/qgslayoutitemmap.h

stale · 2020-04-17T01:10:09Z

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

that all unit tests are passing
that all comments by reviewers have been addressed
that there is enough information for reviewers, in particular
- link to any issues which this pull request fixes
- add a description of workflows which this pull request fixes
- add screenshots if applicable
that you have written unit tests where possible
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
If there is no further activity on this pull request, it will be closed in a week.

alexbruy · 2020-04-23T10:29:59Z

@DelazJ would you mind to address remaining comments?

DelazJ · 2020-04-23T10:38:46Z

They should already be addressed. Anything left?

alexbruy · 2020-04-23T10:41:23Z

There is one missed I think, adding docstring to void mapThemeRenamed()

DelazJ · 2020-04-23T10:46:45Z

No, GitHub artefact. It's in the latest commit

alexbruy · 2020-04-23T10:52:02Z

Ah, sorry.

DelazJ · 2020-04-23T10:55:41Z

np

m-kuhn

So, let's go?

DelazJ · 2020-04-23T14:20:29Z

I'd say "yes!"

nyalldawson reviewed Jan 21, 2020

View reviewed changes

stale bot added stale Uh oh! Seems this work is abandoned, and the PR is about to close. and removed stale Uh oh! Seems this work is abandoned, and the PR is about to close. labels Feb 4, 2020

nyalldawson reviewed Feb 6, 2020

View reviewed changes

src/core/qgsmapthemecollection.h Outdated Show resolved Hide resolved

stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 20, 2020

stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Feb 26, 2020

github-actions bot added this to the 3.14.0 milestone Mar 4, 2020

stale bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 18, 2020

DelazJ force-pushed the renameMapTheme branch from 91b1524 to 0d75f2a Compare March 24, 2020 03:16

stale bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 24, 2020

DelazJ and others added 10 commits March 28, 2020 15:54

[feature] Allow renaming of the current map theme

96baf1b

Keep in sync new map theme name with layout map item visibility

ad43567

If the applied map theme is being renamed, ensure we do not lose that.

Update additional map view canvas when it uses the renamed map theme

be60ea5

Update target version

27ce90d

Make map canvas follow active theme renaming and add test

a7ca951

Apply suggestions from review

e755081

Fix renameMapTheme dox

ee58be5

Co-Authored-By: Nyall Dawson <nyall.dawson@gmail.com>

Update sip file

1ad5c43

Update 3D canvas active map theme name

23585d4

Fix target version

5329f05

DelazJ force-pushed the renameMapTheme branch from 0d75f2a to 5329f05 Compare March 28, 2020 15:00

m-kuhn reviewed Apr 2, 2020

View reviewed changes

src/gui/qgsmapcanvas.h Show resolved Hide resolved

m-kuhn reviewed Apr 2, 2020

View reviewed changes

src/core/layout/qgslayoutitemmap.h Outdated Show resolved Hide resolved

stale bot added stale Uh oh! Seems this work is abandoned, and the PR is about to close. and removed stale Uh oh! Seems this work is abandoned, and the PR is about to close. labels Apr 17, 2020

More doc strings

9fc5985

m-kuhn approved these changes Apr 23, 2020

View reviewed changes

m-kuhn merged commit 5d45b71 into qgis:master Apr 23, 2020

DelazJ added the Feature label May 4, 2020

DelazJ mentioned this pull request May 8, 2020

Being able to rename Preset visibility #22857

Closed

timlinux added Changelog Items that are queued to appear in the visual changelog - remove after harvesting and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels May 22, 2020

DelazJ deleted the renameMapTheme branch February 3, 2021 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Allow renaming of the current map theme #33950

[feature] Allow renaming of the current map theme #33950

DelazJ commented Jan 21, 2020 •

edited

Loading

nyalldawson commented Jan 21, 2020

nyalldawson commented Jan 21, 2020

stale bot commented Feb 4, 2020

DelazJ commented Feb 6, 2020

stale bot commented Feb 20, 2020

DelazJ commented Feb 26, 2020

stale bot commented Mar 18, 2020

DelazJ commented Apr 2, 2020

stale bot commented Apr 17, 2020

alexbruy commented Apr 23, 2020

DelazJ commented Apr 23, 2020

alexbruy commented Apr 23, 2020

DelazJ commented Apr 23, 2020

alexbruy commented Apr 23, 2020

DelazJ commented Apr 23, 2020

m-kuhn left a comment •

edited

Loading

DelazJ commented Apr 23, 2020

[feature] Allow renaming of the current map theme #33950

[feature] Allow renaming of the current map theme #33950

Conversation

DelazJ commented Jan 21, 2020 • edited Loading

nyalldawson commented Jan 21, 2020

nyalldawson commented Jan 21, 2020

stale bot commented Feb 4, 2020

DelazJ commented Feb 6, 2020

stale bot commented Feb 20, 2020

DelazJ commented Feb 26, 2020

stale bot commented Mar 18, 2020

DelazJ commented Apr 2, 2020

stale bot commented Apr 17, 2020

alexbruy commented Apr 23, 2020

DelazJ commented Apr 23, 2020

alexbruy commented Apr 23, 2020

DelazJ commented Apr 23, 2020

alexbruy commented Apr 23, 2020

DelazJ commented Apr 23, 2020

m-kuhn left a comment • edited Loading

Choose a reason for hiding this comment

DelazJ commented Apr 23, 2020

DelazJ commented Jan 21, 2020 •

edited

Loading

m-kuhn left a comment •

edited

Loading