Improve split with lines #3539
Improve split with lines #3539
Conversation
| spatialIndex = vector.spatialindex(splitLayer) | ||
| splitGeoms = {} | ||
|
|
||
| for aSplitFeature in vector.features(splitLayer): |
There was a problem hiding this comment.
You could speed this up a bit by passing a feature request to vector.features which uses setSubsetOfAttributes([]) to avoid fetching the unused attributes.
|
|
||
| outFeat = QgsFeature() | ||
| features = vector.features(layerA) | ||
| total = 100.0 / float(len(features)) |
There was a problem hiding this comment.
you'll need to handle the case that len(features)==0
There was a problem hiding this comment.
You're right, although this would only happen with an empty layer. This was basically a copy-paste operation from some other algo, so I expect to see this line in others, too. But will fix
There was a problem hiding this comment.
Yeah, that's how I know to look out for it... I hit it in some other algorithm with the same block
| outFeat = QgsFeature() | ||
| features = vector.features(layerA) | ||
| total = 100.0 / float(len(features)) | ||
| allowedWkbTypes = [2, #WkbLineString |
There was a problem hiding this comment.
This looks fragile, and doesn't handle Z/M geometries - I'd suggest instead checking the QgsGeometry.type() for QgsWkbTypes.LineGeometry and PolygonGeometry instead, and then using QgsGeometry.isMultipart() to avoid the multipart types.
There was a problem hiding this comment.
Wouldn't it be either Line (type = 1) or Polygon (type = 2) anyways because INPUT_A is set to be either TYPE_VECTOR_POLYGON or TYPE_VECTOR_LINE?
I could skip that altogether and when handling the geometry itself check if it is multipart.
There was a problem hiding this comment.
basically I would prefer to disable multi-layers to be used as input in the first place, but there is no method to do so AFAIK.
|
tests have been removed to have this PR pass the checks. I will add them again in a later PR |
|
Is this PR ready to be reviewed ? |
Yes, from my point of view it is. Is there anything I have to do to have it reviewed? Nyall already did some reviewing (see discussion) on which I already reacted. |
* Use QgsStringMap * Better description * Use new translated metadata methods
- strpos() now relies on a simple string within a string search - regexp_match() now returns pos of a matching regular expression
[expression] strpos() and regexp_match() improvements
…vement [processing] use algorithm description in modeler dependencies dialog
…faults [processing] fix Ogr2OgrToPostGisList algorithm
WMS server: add user setting if custom datasources are allowed in wms…
…arts [FIXBUG] Fix iteration of features in SinglePartsToMultiparts algorithm
This commit restores some pre 3.0 processing behaviour for number inputs. Now, if a number input is required outside of modeller than a spin box will be shown instead of a free text input. Clicking the expression builder button results in an expression which is evaluated immediately to avoid users expecting that the expression will be evaluated per feature.
Export parametric SVG, will fallback symbols for the systems that cannot understand them
accept numeric, file and table field inputs in modeler This allows a non-string parameter to be reused as a string parameter in contexts where it makes sense.
This adds a new input type for expression inputs. Expression inputs can be linked to a parent layer so that the builder shows the correct fields and layer variables. It's designed for two use cases: 1. to be used when an algorithm specifically requires an expression, eg Select by Expression and Extract by Expression. 2. to be potentially used as a replacement input instead of string or number literals in algorithms. Eg - if the simplify algorithm tolerance parameter was replaced with an expression paremeter, then this expression would be evaluated for every feature before simplifying that feature. It would allow parameters to be calculated per feature, as opposed to the current approach of calculating a parameter once before running the algorithm. It would also mean algorithms like "variable distance buffer" would no longer be needed, as a single "buffer" algorithm could then be used for either a fixed distance, field based, or expression based distance.
Qt5py3 Mac fixes
Clean up code, allow setting z/m columns
- use a proper toolbar to match other parts of QGIS - show keyboard shortcuts in toolbar action tooltips - create vector icons to replace PNG ones
[processing] improve the modeler dialog UI and icons
The -DCMAKE_POSITION_INDEPENDENT_CODE=ON resolves to -fPIE instead of -fPIC (on some platforms?) rendering cmake broken.
Rename algorithm SplitLinesWithLines to SplitWithLines Accept polygon as input, too Use only selected lines to split with (if processing is set to use selection only) Issue log message if trying to split multi geometries Update help
to pass test
|
Now this got out of control because I tried |
No description provided.