Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable ssl verification in the Metasearch plugin #36932

Merged
merged 2 commits into from Jun 5, 2020

Conversation

Samweli
Copy link
Contributor

@Samweli Samweli commented Jun 3, 2020

The latest owslib which is used by Metasearch plugin has an option to switch off ssl verification (see geopython/OWSLib#685), this work expose that option to the Metasearch plugin user.

Fixes #35476

Screenshot
metasearch_ssl_fix

cc @gubuntu
cc @tomkralidis

@github-actions github-actions bot added this to the 3.14.0 milestone Jun 3, 2020
@Samweli Samweli closed this Jun 3, 2020
@Samweli Samweli reopened this Jun 3, 2020
@nyalldawson
Copy link
Collaborator

Won't this need a version check to avoid breakage with older versions?

@Samweli
Copy link
Contributor Author

Samweli commented Jun 4, 2020

Won't this need a version check to avoid breakage with older versions?

No, it won't need a version check. The owslib API hasn't changed.

@Samweli
Copy link
Contributor Author

Samweli commented Jun 4, 2020

@nyalldawson is it okay to backport this to QGIS 3.10?

@nyalldawson nyalldawson closed this Jun 4, 2020
@nyalldawson nyalldawson reopened this Jun 4, 2020
@nyalldawson
Copy link
Collaborator

is it okay to backport this to QGIS 3.10?

Yes, but with the one release delay to avoid regressions

@tomkralidis
Copy link
Contributor

FYI OWSLib 0.20.0 (with @Samweli's fix) has been released.

@DelazJ
Copy link
Contributor

DelazJ commented Jun 10, 2020

I just build master on Ubuntu 18.04 and got at launch (MetaSearch disabled)

from owslib.util import Authentication
ImportError: cannot import name 'Authentication'

@tomkralidis
Copy link
Contributor

We need OWSLib 0.20.0 (which was release last week). How are Python 3rd party deps managed currently?

@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Jun 12, 2020

@Samweli, please see #37175 QGIS 3.13.0-Master "ImportError: cannot import name 'Authentication' from 'owslib.util'" on Windows

@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Jun 12, 2020
@qgis-bot
Copy link
Collaborator

@Samweli
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@Samweli
A documentation ticket has been opened at qgis/QGIS-Documentation#5691
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@Samweli
Copy link
Contributor Author

Samweli commented Jun 14, 2020

@Samweli, please see #37175 QGIS 3.13.0-Master "ImportError: cannot import name 'Authentication' from 'owslib.util'" on Windows

Ok @agiudiceandrea, thanks for pointing it out! I have provided a fix here #37198

@agiudiceandrea
Copy link
Contributor

OSWLib 0.20.0 now available on OSGeo4W https://trac.osgeo.org/osgeo4w/ticket/633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metasearch certificate error
6 participants