-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature][processing] Add a last_value function to the aggregate algorithm #42587
Conversation
@nirvn A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we get a test too please?
@nyalldawson , I couldn't spot a test for the aggregate alg. the begin with. Since the header indicates you're the author I had assumed you thought the underlying aggregate functions were well tested 😉 |
I just ported from python -- I didn't write this one. Isn't there tests in the standard processing yml test files? |
@nyalldawson , ohh, that's possible. I was looking for "native:aggregate", it's probably IDed as "qgis:aggregate". |
efd6782
to
587ec1f
Compare
@nyalldawson , test added which revealed a bug in the code, so as always, good suggestion. |
@nirvn |
Description
This PR adds a new
last_value
aggregation method to processing's aggregate algorithm. It's an handy method to have when the dataset being aggregated has a meaningful ordering.