Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QgsRasterTransparencyWidget in raster properties dlg #45063

Merged

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 14, 2021

Remove a bunch of duplicated code and fix #44949

@elpaso elpaso added Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience labels Sep 14, 2021
@github-actions github-actions bot added this to the 3.22.0 milestone Sep 14, 2021
@elpaso
Copy link
Contributor Author

elpaso commented Sep 14, 2021

CC @DelazJ , I'd appreciate if you could test this one.

@elpaso elpaso merged commit f59947a into qgis:master Sep 16, 2021
@elpaso elpaso deleted the bugfix-gh44949-raster-properties-transparency-dedup branch September 16, 2021 08:48
@DelazJ
Copy link
Contributor

DelazJ commented Sep 16, 2021

@elpaso I downloaded the Windows artifact but my Windows is somehow blocking me from running it 😠 (security blah blah) and when deactivated I can't pass the "Setting up the GUI..." step.
Will test in the next build

@DelazJ
Copy link
Contributor

DelazJ commented Sep 17, 2021

@elpaso tested and I think I found an issue: the layer styling panel is not automatically updated if you do the change in layer properties dialog
rastertransparencybug

@elpaso
Copy link
Contributor Author

elpaso commented Sep 18, 2021

@DelazJ if this issue was already present before my patch can you please file a separate issue?

@DelazJ
Copy link
Contributor

DelazJ commented Sep 18, 2021

No chance it could have popped up given that the "display nodata as" color widget was absent in layer properties before your patch (this was the reported issue, besides the code duplicate Nyall noticed). But I opened #45132 for reference.

@elpaso
Copy link
Contributor Author

elpaso commented Sep 18, 2021

Yeah, of course. I should have read your comment more carefully 🙃.

It is probably unrelated to my patch though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Display no data value as" option is not available in raster layer properties
3 participants