Unify UX behavior, pt 2: rotation #4646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
added
the
API Break!
|
Great, it was SO annoying! |
Fix qgis#15823 Also reenable instant map refresh as map rotation changes. Since map refresh is done in the background now, this is safe to reenable.
Label rotation is now specified in degrees clockwise, just like symbol rotation, map rotation, etc. Fix qgis#4518
|
@nyalldawson Thanks for the fix. Any reason to have let the description of DD button beside rotation spinbox state that expected inputs are from 0 to 360 while it can also take -360 to 0 values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the behavior of controls for specifying rotation, so that all rotation is set in degrees clockwise, and accepts values from -360->360.
It also implements an important fix where label rotation is changed to operate in the same direction (clockwise), so that it matches symbology, map rotation, etc.