Fix #47089 wrong rotation point for rotate label tool preview #47124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Feb 2, 2022
|
Let's delay this till after 3.24.0 final to be safe. It's not a new regression, so the risk outweighs the reward of a merge at this stage. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
|
any objection to merge this one? |
nyalldawson
reviewed
Mar 15, 2022
|
Looks good to me -- I've just the one question about why the existing test result has changed |
nyalldawson
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47089 wrong rotation point for rotate label tool preview