Untwine upstream updates - unicode path fixes on windows #48583
Conversation
|
|
||
| try | ||
| { | ||
| fs::directory_iterator it(untwine::toNative(dir)); |
There was a problem hiding this comment.
this breaks build on macos when the target is less than 10.15 which is not realistic for now.
Any chance to bring a code which would compile on 10.13?
see qgis/QGIS-Mac-Packager#150
There was a problem hiding this comment.
@hobu @abellgithub Unfortunately it looks like the recent untwine update breaks QGIS macOS build. Would it be possible to update untwine code so that it compiles on macos 10.13 as well?
|
Hi @wonder-sk, it looks like the same issue (or a similar one) allegedly fixed by this PR and subsequent one (#48747, #49032, #49703, ...) is occurring again: please see #57913. |
|
Indeed this was a regression due to a pull request that attempted to make MinGW work for Untwine. See hobuinc/untwine#167 for more details. |
|
Thanks @hobu. Anyway I've tested QGIS 3.38.0, 3.34.8, 3.28.15, 3.26.3 and 3.22.16 and it seems to me the issue occurs in all such versions as it was never actually fixed. |
Fixes #41833