Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server: add QGIS_SERVER_ALLOWED_EXTRA_SQL_TOKENS settings var #50127

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Server: add QGIS_SERVER_ALLOWED_EXTRA_SQL_TOKENS settings var #50127

merged 5 commits into from
Sep 8, 2022

Conversation

elpaso
Copy link
Contributor

@elpaso elpaso commented Sep 7, 2022 •
edited
Loading

This new feature allows to specify extra tokens allowed for WMS FILTER definition.

The current list of accepted tokens is rather small and this setting will allow the sysadmins to enlarge the list of allowed tokens.

Funded by: Zweckverband Grevesmühlen

@elpaso elpaso added Feature Server Related to QGIS server labels Sep 7, 2022
@github-actions github-actions bot added this to the 3.28.0 milestone Sep 7, 2022
@Gustry Gustry added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

@elpaso
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

Gustry
Gustry reviewed Sep 7, 2022
View reviewed changes
src/server/qgsserversettings.cpp Outdated Show resolved Hide resolved
src/server/qgsserversettings.h Outdated Show resolved Hide resolved
src/server/qgsserversettings.h Outdated Show resolved Hide resolved
@Gustry Gustry added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Sep 7, 2022
@elpaso
Server: add QGIS_SERVER_ALLOWED_EXTRA_SQL_TOKENS settings var
2beed83 
This new feature allows to specify extra tokens allowed for
WMS FILTER definition.

The current list of accepted tokens is rather small and
this setting will allow the sysadmins to enlarge the list
of allowed tokens.
@elpaso
Typos
65baa23
@elpaso elpaso force-pushed the server-sql-extra-allowed-tokens branch from d615495 to 65baa23 Compare September 7, 2022 14:40
@elpaso
Copy link
Contributor Author

elpaso commented Sep 7, 2022

@Gustry thanks for the review!

@elpaso elpaso merged commit 751deda into qgis:master Sep 8, 2022
@elpaso elpaso deleted the server-sql-extra-allowed-tokens branch September 8, 2022 10:12
@qgis-bot qgis-bot mentioned this pull request Sep 8, 2022
Closed
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

@elpaso
A documentation ticket has been opened at qgis/QGIS-Documentation#7768
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Gustry left review comments

Assignees
No one assigned
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Server Related to QGIS server
Projects
None yet
Milestone
3.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elpaso @Gustry @zacharlie