-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add g.version algorithm #55894
Add g.version algorithm #55894
Conversation
Having said that, I don't think there's any reason this couldn't be rectified at a later date. But if there's a preference to use one standard name such as MESSAGES it would be better to make that decision first.
Actually, my first thought was that it would be good to always (for all GRASS algorithms) save the messages GRASS prints to an output called 'MESSAGES' or something, but I thought there may be a reason for an algorithm to create more than one output like this, and in any case I decided I wasn't proficient enough to mess with the code that prints the GRASS outputs to the dialog when there is no html output. |
@@ -340,6 +341,7 @@ def on_complete(ok, results): | |||
|
|||
def finish(self, successful, result, context, feedback, in_place=False): | |||
keepOpen = not successful or ProcessingConfig.getSetting(ProcessingConfig.KEEP_DIALOG_OPEN) | |||
HtmlOutputs = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a separate PR for this fix? It's unrelated to the grass ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a separate PR for this fix? It's unrelated to the grass ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you update this PR and remove that commit now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted, squashed and force-pushed. Hopefully that's the proper way to do this!
…t the GRASS version
… variable as well as html
ResourceWarning: unclosed file
Done, but if I need to amend those commit messages that refer to grass7.txt I'll need to come back tomorrow to do it. |
Description
This allows code to get the actual version number:
It also allows code to install a grass addon if it isn't already installed:
History
Notes
src/core/processing/qgsprocessingfeedback.cpp
: