-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display more columns in the "Export Project to Dxf" dialog (take 2 ) #57401
Conversation
These were somehow of a hack and complicates the widget handling with columns addition
Also clean up ui file, add spacing and set convenient behavior and default width for columns
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist. |
Sorry to say, but a dialog that shows only half of its options is BUGGY and less useful. |
This PR is an alternative approach to #57155: instead of a QgsLayerTreeView it uses a QTreeView for automatically displaying all the columns in the dialog. This seems to be the actual widget type used in the other dialogs that display layer tree along with other columns (see #57155 (comment)).
It reverts #56082 that looks more like a hack to me, as we need to adjust width bounds whenever number of columns changes.
dxfColumnsSize.mp4
The bad news: it doesn't work. I can get the dialog with columns visible and I could export a project. But some interactions with the dialog (e.g. double-click in a cell, resizing dialog not the columns) lead to a freeze then a crash (of my whole computer). An issue with the Q_ASSERT below but this is a too high level for my c++ understanding.
QGIS/src/app/qgsdxfexportdialog.cpp
Lines 151 to 154 in 8d9c68b