Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to display more columns in the "Export Project to Dxf" dialog #57155

Closed
wants to merge 1 commit into from

Conversation

DelazJ
Copy link
Contributor

@DelazJ DelazJ commented Apr 15, 2024

I don't think this is the most sustainable fix (being able to automatically pass the number of expected columns may be) but it should help fix resurrection of #45441, and avoid hiding the data-defined blocks columns.

That said, I fail to understand why this widget behaves differently to the other ones in which a treeview is involved (let's say the "layer capabilities" or "QGIS Server --> WMTS" in the project properties dialog, ...)

@github-actions github-actions bot added this to the 3.38.0 milestone Apr 15, 2024
@DelazJ
Copy link
Contributor Author

DelazJ commented Apr 15, 2024

No more artifact generation for Windows?

@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Apr 17, 2024

No more artifact generation for Windows?

It looks like they are created https://github.com/qgis/QGIS/actions/runs/8685776406?pr=57155 but the automatic comment is no longer added.

@agiudiceandrea agiudiceandrea added DXF/DWG Relating to DXF or DWG importing/exporting GUI/UX Related to QGIS application GUI or User Experience Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Apr 17, 2024
@nyalldawson
Copy link
Collaborator

nyalldawson commented Apr 17, 2024

I think there's a bug in GitHub itself. The workflows no longer trigger, and there's not even any record of them attempting to run. I was going to give it a couple of weeks and see if it resolves itself... 🤷‍♂️

Copy link

github-actions bot commented May 2, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 2, 2024
Copy link

github-actions bot commented May 9, 2024

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this May 9, 2024
@DelazJ
Copy link
Contributor Author

DelazJ commented May 12, 2024

That said, I fail to understand why this widget behaves differently to the other ones in which a treeview is involved (let's say the "layer capabilities" or "QGIS Server --> WMTS" in the project properties dialog, ...)

Replying to self: the widgets in the ui file of these dialogs DO NOT use QgsLayerTreeView; they use QTreeView. And investigating further, QgsLayerTreeView seems to appear only in "layout legend widget" and "embed layers and groups" ui files. And the particularity of these dialogs is that they show a SINGLE column that takes all the available width.
--> Could it be that QgsLayerTreeView is not meant to display more than one column?
Answering this is beyond my skills so hopefully someone else can give it a look?
I've tried an alternative approach using QTreeview that does not really work. See #57401

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants