Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Avoid %2B to be interpreted as space in querystring #6879

Merged

Conversation

arnaud-morvan
Copy link
Contributor

@arnaud-morvan arnaud-morvan commented Apr 27, 2018

If '+' is replaced by ' ' after percent decoding, '%2B' is interpreted as ' '.

Fix this by replacing '+' by '%20' before percent decoding.

PR open as bug fix on release-3_0, needs to be cherry-picked in master too.

Description

Include a few sentences describing the overall goals for this PR (pull request). If applicable also add screenshots.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and containt sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

If '+' is replaced by ' ' after percent decoding, '%2B' is interpreted as ' '.

Fix this by replacing '+' by '%20' before percent decoding.
@rldhont rldhont added this to the 3.0.x milestone May 2, 2018
@rldhont rldhont merged commit 9e5f382 into qgis:release-3_0 May 2, 2018
@arnaud-morvan arnaud-morvan deleted the server_fix_url_params_decoding branch June 6, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants