Issue3243 taking crs into account with bookmarks #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@jef-n can you take a look at this ticket for me to see if we can merge it. |
jef-n
pushed a commit
that referenced
this pull request
Jan 28, 2012
Richard Duivenvoorde (from pull request #78) - crs taking into account, bookmarklist is now editable qtreeview - set better column names the column names from the table Juergen Fischer added refactoring: - move adding bookmarks into QgsBookmarks - make QgsBookmarks a singleton - delete multiple entries at once
|
pull and refactored in 3c45355 |
alexbruy
pushed a commit
that referenced
this pull request
Mar 4, 2012
Richard Duivenvoorde (from pull request #78) - crs taking into account, bookmarklist is now editable qtreeview - set better column names the column names from the table Juergen Fischer added refactoring: - move adding bookmarks into QgsBookmarks - make QgsBookmarks a singleton - delete multiple entries at once
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 3243 is about taking crs into account with bookmarks.
So first: added valid crsid in database for every bookmark when making a bookmark
second take it into account when using 'zoomto bookmark'
In the ticket there is also the wish to be able to edit values.
When looking into that it seems easier to change the widget to a view with a QSqlTableModel model behind it,
AND using QSqlDatabase (for which I'm not sure if that is ok for QGIS)
Now you can use a bookmark (which has a crs in the db) in different projects
You can edit name, project, xyxy by clicking F2
Sorry, these are two changesets, I do not know how to merge these into one. If it is problematic I can try do this in a new branch and merge both changeset myself.