Fix #8507

[christianurich]

As described in http://hub.qgis.org/issues/8507 master doesn't compile with sip 4.15. (I'm using OSX 10.8 and sip 4.15.1.)

The quick fix was moving methods from private to protected solved the compiling error.

[mhugent]

I'd prefer the long fix in favour of the quick fix. We shouldn't change the core classes for the sake of the bindings.

[m-kuhn]

I merged that one already.
The "quick fix" actually looks like a proper fix to me. A notification method which is implemented in a subclass should actually be protected and not private.

[m-kuhn]

@mhugent please let me know if you think this should be fixed in a different way. Closing this for the moment, as the code is in master.

[mhugent]

Oh, I see. Didn't realize the methods come from the upper class. So yes, it seems indeed to be a proper fix.

[samtux]

I updated the GIT repository but error persist in Arch Linux:

Scanning dependencies of target python_module_qgis_gui
[ 92%] Building CXX object python/CMakeFiles/python_module_qgis_gui.dir/gui/sipguipart0.cpp.o
[ 92%] Building CXX object python/CMakeFiles/python_module_qgis_gui.dir/gui/sipguipart1.cpp.o
[ 92%] Building CXX object python/CMakeFiles/python_module_qgis_gui.dir/gui/sipguipart2.cpp.o
[ 92%] Building CXX object python/CMakeFiles/python_module_qgis_gui.dir/gui/sipguipart3.cpp.o
/usr/share/sip/QtGui/qsyntaxhighlighter.sip: En la función ‘PyObject* meth_QgsExpressionHighlighter_setCurrentBlockUserData(PyObject*, PyObject*, PyObject*)’:
/usr/share/sip/QtGui/qsyntaxhighlighter.sip:78:77: error: ‘qtgui_wrap_ancestors’ no se declaró en este ámbito
PyObject *py_td = qtgui_wrap_ancestors(td, sipType_QTextDocument);
^
make[2]: *** [python/CMakeFiles/python_module_qgis_gui.dir/gui/sipguipart3.cpp.o] Error 1
make[1]: *** [python/CMakeFiles/python_module_qgis_gui.dir/all] Error 2
make: *** [all] Error 2
==> ERROR: Se produjo un error en build().
Cancelando...