Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve csv output #103

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Improve csv output #103

merged 5 commits into from
Jun 9, 2020

Conversation

FlavBd
Copy link
Contributor

@FlavBd FlavBd commented Apr 22, 2020

Generate one csv file per exported layer and zip them for the user.

Before results.csv :

parcelle,,
,gid,529100
,id,14118000IB0072
,commune,14118
,prefixe,0
,section,IB
,numero,72
,contenance,36281
,created,2001-09-28
,updated,2015-03-26
,geometry,"MULTIPOLYGON ... "
,,
commune,,
,gid,245
,id,14118
,nom,CAEN
,created,2001-11-22
,updated,2018-04-19
,geometry,"MULTIPOLYGON ... "

After commune.csv :

gid;id;nom;created;updated;geometry
245;14118;CAEN;2001-11-22;2018-04-19;MULTIPOLYGON ...
302;14327;HEROUVILLE SAINT CLAIR;2002-11-28;2018-04-23;MULTIPOLYGON ...
335;14437;MONDEVILLE;2002-12-05;2016-11-17;MULTIPOLYGON ...

Fix qgis/qwc2-demo-app#194

@FlavBd FlavBd changed the title [WIP] Improve csv output Improve csv output Apr 22, 2020
@manisandro
Copy link
Member

Thanks, I wonder whether it's better to make this an alternative format (like csv+zip), as people might already be relying on the current csv format.

@FlavBd
Copy link
Contributor Author

FlavBd commented May 4, 2020

Thanks for your advice.
Like I explain in this issue : qgis/qwc2-demo-app#198 I'm working on the possibility to choose through different format.
Here is an idea of the result.
image
For the moment the two possibilities are json and csv but I can add csv + zip like you suggest and keep the current csv format.

@FlavBd
Copy link
Contributor Author

FlavBd commented May 27, 2020

@manisandro what do you think about the suggestion to choose through different format and to have csv and csv + zip possibilities ? Can I continue in this way?

@manisandro
Copy link
Member

Yes I'm ok with that, thanks.

@FlavBd
Copy link
Contributor Author

FlavBd commented Jun 5, 2020

@manisandro I made new commits about the csv export, don't hesitate to tell me if you want some modifications

@manisandro manisandro merged commit 16dbdfe into qgis:master Jun 9, 2020
@manisandro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve csv output
2 participants