Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in Qibo repository fail with AMD ROCm #34

Closed
mlazzarin opened this issue Oct 25, 2021 · 4 comments
Closed

Tests in Qibo repository fail with AMD ROCm #34

mlazzarin opened this issue Oct 25, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@mlazzarin
Copy link
Contributor

mlazzarin commented Oct 25, 2021

When using an AMD GPU, the tests in the Qibo repository fail.
On my setup, I get 92 failed tests, in particular:

  • rocblas_status_not_implemented errors, related to some linear algebra methods e.g. eigh.
  • Assertion errors
  • Some Type errors (but they seem to disappear with PR Fix template kernels with ROCm #33).

The tests in this repository are fine, though.

@mlazzarin mlazzarin added the bug Something isn't working label Oct 25, 2021
@mlazzarin
Copy link
Contributor Author

More details:

  • rocblas_status_not_implemented errors: they appear when a linear algebra method like eigh or eigvalsh is called.
    I guess this means that rocblas doesn't implement these methods yet.
    Possible solution: fall back to CPU for those particular methods.
  • AssertionError: they appear in
    • test_core_measurements.py::test_measurementresult_apply_bitflips
    • test_measurement_gate_probabilistic.py::test_probabilistic_measurement
    • test_measurement_gate_probabilistic.py::test_unbalanced_probabilistic_measurement
    • test_measurement_gate_probabilistic.py::test_post_measurement_bitflips_on_circuit

@scarrazza
Copy link
Member

I confirm qibojit tests are passing, but only if I set manually the LLVM_PATH.
The other crashes are due to the different seed/random generator and the missing implementations.

That being said, I believe we can accept this trade-off with the catching exception mechanism you have proposed.

@mlazzarin
Copy link
Contributor Author

Ok, given that we are planning to move the backend "drivers" from the qibo repository to each backend repo, it may be convenient to wait for that before fixing this issue.

@mlazzarin
Copy link
Contributor Author

The issue is now fixed, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants