reserved identifier violation

[elfring]

I would like to point out that identifiers like "__QCONF_CMD_H__" and "__QCONF_COMMON_H__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

[haveTryTwo]

Thanks for your advise!
The "Noncompliant Code Example" : #define _MY_HEADER_H_ , and the reason why it's noncompliant is "The name may clash with reserved names defined by the implementation of the C++ standard template library in its headers or with reserved names implicitly predefined by the compiler even when no C++ standard library header is included"; and the macro defined in C++ standard template library may be like #ifndef _GLIBCXX_ISTREAM that begins with an underscore, so avoiding using leading or trailing underscores in the name of the header guard may be compliant solution.
But this may be not only one compliant solution! The 'Google C++ Style Guide' advise the symbol name should be : #define PROJECT_PATH_FILE_H_ . I think if it can achieve the purpose that not clash with reserved names defined by the C++ standard template, the macro that begins and ends with double underscore may be also ok.
Do you think so?

[elfring]

It is popular to use a suffix like "_H" for include guards. - There are better ways to make your identifiers reasonably unique.

Would you like to avoid that your software depends on undefined behaviour?

[haveTryTwo]

To make our identifiers unique, we'll take your advice, thanks again!

[elfring]

Thanks for your improvement of affected include guards.