Skip to content
This repository has been archived by the owner on Sep 23, 2023. It is now read-only.

Update metadata getter #647

Merged
merged 4 commits into from
Mar 20, 2014
Merged

Conversation

adamrp
Copy link
Member

@adamrp adamrp commented Mar 19, 2014

Now it accepts either a file as input, or a comma-separated list of barcodes, or both, just for convenience

all_barcodes = []

if input_fp is None and barcodes is None:
raise IOError("Must supply either -i or -b")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use option_parser.error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, I meant to do that! I couldn't remember the error type at first. Changing!

@ElDeveloper
Copy link
Member

Thanks!

@teravest
Copy link
Contributor

Looks good

ElDeveloper added a commit that referenced this pull request Mar 20, 2014
@ElDeveloper ElDeveloper merged commit 8931ca5 into qiime:master Mar 20, 2014
@ElDeveloper
Copy link
Member

Thanks @adamrp!!

Yoshiki Vázquez-Baeza

On Mar 20, 2014, at 10:43 AM, teravest notifications@github.com wrote:

Looks good


Reply to this email directly or view it on GitHub.

@adamrp adamrp deleted the update_metadata_getter branch March 21, 2014 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants