-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically drop NaN
values when executing ancom.py
#82
Conversation
…cludes them from analysis and proceeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @valentynbez,
Thank you so much for this, and we're really sorry we didn't get back to you sooner.
We'd ideally handle this via an initial error with a new parameter which could override the error, instead of always allowing it through with a log entry.
The reason for that is a user may not realize they have missing entries, so the positive affirmation to filter is a useful sanity check for them in the event they didn't realize.
I realize this is so late a response that it's unfair to expect any changes at this point, so I'm going to create an issue and reference this PR as an initial implementation for your feature.
Closing this for now in favor of #90 because we're going to rework some of the details, but let me know if you'd like me to re-open this if you're still interested. |
During the analysis, I had some missing metadata values. To counter it I had to:
feature-table
stepfilter
it, filter thancollapse
itadd_pseudocount
ancom
Missing values in metadata are human-introduced errors, they appear quite often. This is an inconvenient workflow for the user.
Instead of raising an error when metadata has
nan
entries, I propose ANCOM would proceed and inform the user which samples were excluded from analysis if any.