-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: ANCOM-BC R wrapper #88
Conversation
…a couple of additional guards
Alright @ebolyen I think this one's ready for a semi-final review. Only thing that remains to be finished is:
And of course anything else that I may have missed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Some parts, like the usage examples and the tests, I don't really feel like I can give solid feedback on because I'm not sure exactly what needs to be covered, but it looks like you hit the relevant points.
Hmm turns out I don't know how to select an entire block of code to show in the preview window thing on the comment. Hopefully, it's obvious what I'm talking about anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done @lizgehret. The R code is quite aesthetic relative to most R code out there.
Few very minor comments on the plugin-setup parameter descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lizgehret!
New method in q2-composition that wraps the ANCOM-BC functionality from this R package. I used some of @mortonjt's ideas from his q2-ancombc plugin, but added some additional guards, and have wrapped up the outputs differently.
The contents of this PR include:
ancombc
that produces an artifact containing the following:ancombc
method