Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove features and show warning in plot #88

Merged
merged 7 commits into from
Nov 24, 2020

Conversation

ElDeveloper
Copy link
Member

Biplot arrows are now ignored in the plot method.

Biplot arrows are now ignored in the plot method.

Fixes qiime2#76
@thermokarst thermokarst added this to In Review in 2020.11 via automation Oct 30, 2020
q2_emperor/_plot.py Outdated Show resolved Hide resolved
@thermokarst thermokarst moved this from In Review to In Analysis in 2020.11 Nov 16, 2020
@thermokarst thermokarst moved this from In Analysis to In Review in 2020.11 Nov 19, 2020
@thermokarst thermokarst linked an issue Nov 23, 2020 that may be closed by this pull request
q2_emperor/_plot.py Outdated Show resolved Hide resolved
q2_emperor/plugin_setup.py Outdated Show resolved Hide resolved
@thermokarst thermokarst moved this from In Review to In Development in 2020.11 Nov 23, 2020
ElDeveloper and others added 3 commits November 23, 2020 12:03
Co-authored-by: Matthew Dillon <matthewrdillon@gmail.com>
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed up a small commit with some tests (and linting edits).

q2_emperor/_plot.py Outdated Show resolved Hide resolved
q2_emperor/_plot.py Outdated Show resolved Hide resolved
@thermokarst thermokarst merged commit 5a59f92 into qiime2:master Nov 24, 2020
2020.11 automation moved this from In Development to Changelog Needed Nov 24, 2020
@ElDeveloper
Copy link
Member Author

ElDeveloper commented Nov 24, 2020 via email

@thermokarst thermokarst moved this from Changelog Needed to Completed in 2020.11 Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2020.11
Completed
Development

Successfully merging this pull request may close these issues.

qiime emperor plot should ignore feature attributes
2 participants