-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Remove features and show warning in plot #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Biplot arrows are now ignored in the plot method. Fixes qiime2#76
thermokarst
reviewed
Nov 16, 2020
Thanks for the suggestion @thermokarst
thermokarst
suggested changes
Nov 23, 2020
Co-authored-by: Matthew Dillon <matthewrdillon@gmail.com>
thermokarst
reviewed
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed up a small commit with some tests (and linting edits).
ElDeveloper
commented
Nov 23, 2020
thermokarst
approved these changes
Nov 24, 2020
Thanks so much @thermokarst!
…On (Nov-23-20|16:10), Matthew Dillon wrote:
@thermokarst approved this pull request.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
https://urldefense.com/v3/__https://github.com/qiime2/q2-emperor/pull/88*pullrequestreview-536942026__;Iw!!Mih3wA!V0q5OCdtoox3V2QDL9-Dun2YBOCfUp0I7XRa-GxK8s-1-kWZoIeWwuSkhHisupU$
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biplot arrows are now ignored in the plot method.