This repository has been archived by the owner on Dec 29, 2023. It is now read-only.
BUG: Raise exception when samples in table not present in metadata #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thermokarst
suggested changes
Aug 8, 2019
There was a problem hiding this comment.
Thanks @Oddant1! One minor test-request, inline, otherwise GTG!
thermokarst
approved these changes
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25 The only relevant non-deprecated method I found for this was
gradient_clustering, it now defaults to excepting if there are any samples present in the table that are not in the metadata and has anignore_missing_samplesparameter to intentionally bypass this check.