Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin documentation suggestions: #6

Closed
gregcaporaso opened this issue Oct 16, 2017 · 1 comment · Fixed by #10
Closed

plugin documentation suggestions: #6

gregcaporaso opened this issue Oct 16, 2017 · 1 comment · Fixed by #10

Comments

@gregcaporaso
Copy link
Member

gregcaporaso commented Oct 16, 2017

threads parameter should be a range bound on the lower end. Also, note that this is only relevant for vsearch?

https://github.com/nbokulich/q2-quality-control/blob/6d89fbebe9557fde5c7a1ffef1c542564d8e551d/q2_quality_control/plugin_setup.py#L38

The following:
https://github.com/nbokulich/q2-quality-control/blob/6d89fbebe9557fde5c7a1ffef1c542564d8e551d/q2_quality_control/plugin_setup.py#L50

would be more clear as: BLAST expectation (E) value threshold

This description should mention the E-value threshold too, and how that interacts with percent identity (i.e., do both need to be above their respective thresholds)? Sort of related, but should it be possible to disable the percent identity filter, and only filter based on E-value?

https://github.com/nbokulich/q2-quality-control/blob/6d89fbebe9557fde5c7a1ffef1c542564d8e551d/q2_quality_control/plugin_setup.py#L64

@gregcaporaso gregcaporaso changed the title threads parameter should be a range bound on the lower end plugin documentation suggestions: Oct 16, 2017
@nbokulich
Copy link
Member

e value and perc_identity are both used for filtering, and hence to be accepted as a hit a sequence must have a lower E and higher identity than the respective thresholds. This is now noted in the description.

Default E val is now set to the default used in blastn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants