-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMP: Add transformer from slpssefdf to Casava #226
Closed
Closed
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9283fba
IMP: Add transformer from casava to slpssefdf
Oddant1 dbb860f
SQUASH: Fix linter error
Oddant1 3f357bc
SQUASH: Make the test actually work
Oddant1 cd73fa3
SQUASH: Clean up transformer
Oddant1 37378aa
SQUASH: Addressing @thermokarst's review
Oddant1 30d45a1
SQUASH: Addressing @thermokarst's review
Oddant1 734f01c
SQUASH: Clean up linting
Oddant1 f019e10
SQUASH: Change transformer numbers
Oddant1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DBC: Why not keep this as
_12
, and name the new one_27
? Just so you know, with transformers the names of the functions don't matter, we just took the strategy of naming them_number
, but it can be anythingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, probably just because I saw
_10
,_11
and was bothered at the idea of the next thing being_27
but I guess the rest isn't in numerical order anyway 😆