Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMP: Implement AlignedDNAFASTAFormat validation #249

Merged
merged 6 commits into from
Aug 11, 2020
Merged

IMP: Implement AlignedDNAFASTAFormat validation #249

merged 6 commits into from
Aug 11, 2020

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jul 9, 2020

Start doing for AlignedDNAFASTAFormat what #214 did for DNAFASTAFormat

@Oddant1 Oddant1 added this to In Review in 2020.8 via automation Jul 9, 2020
@Oddant1 Oddant1 moved this from In Review to In Development in 2020.8 Jul 9, 2020
@Oddant1 Oddant1 moved this from In Development to In Review in 2020.8 Jul 9, 2020
@Oddant1
Copy link
Member Author

Oddant1 commented Jul 9, 2020

@thermokarst the code should be more DRY now

@thermokarst
Copy link
Contributor

🏜️

thermokarst
thermokarst suggested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor comments and suggestions inline.

q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
@thermokarst thermokarst assigned Oddant1 and unassigned thermokarst Jul 24, 2020
@thermokarst thermokarst moved this from In Review to In Development in 2020.8 Jul 24, 2020
@Oddant1 Oddant1 assigned thermokarst and unassigned Oddant1 Jul 24, 2020
@Oddant1 Oddant1 moved this from In Development to In Review in 2020.8 Jul 24, 2020
thermokarst
thermokarst suggested changes Jul 27, 2020
View reviewed changes
q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
q2_types/feature_data/_format.py Outdated Show resolved Hide resolved
@thermokarst thermokarst moved this from In Review to In Development in 2020.8 Jul 27, 2020
@thermokarst thermokarst assigned Oddant1 and unassigned thermokarst Jul 27, 2020
@Oddant1 Oddant1 moved this from In Development to In Review in 2020.8 Jul 28, 2020
@Oddant1 Oddant1 assigned thermokarst and unassigned Oddant1 Jul 28, 2020
@thermokarst thermokarst merged commit 706ed13 into qiime2:master Aug 11, 2020
2020.8 automation moved this from In Review to Changelog Needed Aug 11, 2020
@Oddant1 Oddant1 moved this from Changelog Needed to Completed in 2020.8 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thermokarst thermokarst thermokarst approved these changes

Assignees

@thermokarst thermokarst

Labels
None yet
Projects
No open projects
2020.8
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Oddant1 @thermokarst