Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Add format, transformer, and type tests to FeatureData #60

Merged
merged 5 commits into from
Oct 7, 2016
Merged

TST: Add format, transformer, and type tests to FeatureData #60

merged 5 commits into from
Oct 7, 2016

Conversation

jakereps
Copy link
Member

@jakereps jakereps commented Sep 23, 2016

Committing by test type to allow looking at individual package diffs.

Resolves #42

@jakereps jakereps changed the title TST: Add format, transformer, and type tests to all packages TST: Add format, transformer, and type tests to FeatureData Sep 26, 2016
@thermokarst thermokarst self-assigned this Sep 26, 2016
@jakereps
Copy link
Member Author

Tests will fail until qiime2/qiime2/pull/152 is merged.

@jakereps
Copy link
Member Author

I'll revisit the transformer tests on this one tomorrow, because they are really gross. FeatureTable went along a little more nicely, but all the background df magic in this one makes it hard to compare ins and outs on the tests without mimicking the magic leading to tons of hideous code.

@thermokarst
Copy link
Contributor

@jakereps: is this ready for review now? No rush either way, just didn't want to review if you weren't ready yet. Thanks!

@jakereps
Copy link
Member Author

jakereps commented Oct 5, 2016

The only part that will most likely change or have to be changed if it is reviewed now is the transformer tests. Is it ok to import the helpers used within the transformers to clean things up a bit? There is some black magic going on behind the scenes with the data frames, and having to replicate it for every test adds a ridiculous amount of redundant code (I think I stripped a bunch out on my last reviewing and just had it validate the returned type on some)

@jakereps
Copy link
Member Author

jakereps commented Oct 5, 2016

@thermokarst, I took a swing at semi, hopefully, maybe, cleaning up the transformer tests, so this should be ready for review!

Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @jakereps!

@thermokarst thermokarst merged commit 256c4b4 into qiime2:master Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants