-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Add format, transformer, and type tests to FeatureData #60
Conversation
Tests will fail until qiime2/qiime2/pull/152 is merged. |
I'll revisit the transformer tests on this one tomorrow, because they are really gross. FeatureTable went along a little more nicely, but all the background |
@jakereps: is this ready for review now? No rush either way, just didn't want to review if you weren't ready yet. Thanks! |
The only part that will most likely change or have to be changed if it is reviewed now is the transformer tests. Is it ok to import the helpers used within the transformers to clean things up a bit? There is some black magic going on behind the scenes with the data frames, and having to replicate it for every test adds a ridiculous amount of redundant code (I think I stripped a bunch out on my last reviewing and just had it validate the returned type on some) |
@thermokarst, I took a swing at semi, hopefully, maybe, cleaning up the transformer tests, so this should be ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @jakereps!
Committing by test type to allow looking at individual package diffs.
Resolves #42