Add data_type_id column to preprocessed and processed data tables #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…origin' into add-data-type-to-preproc-proc-data
| Returns | ||
| ------- | ||
| str or int | ||
| string value of data_type or data_type_id |
There was a problem hiding this comment.
can you indicate here when would it be a string and when would it be an int?
There was a problem hiding this comment.
@squirrelo, I think you missed this comment.
There was a problem hiding this comment.
Ah, it is in two places. Got the other one you missed and missed this one.
There was a problem hiding this comment.
Ok, that's weird. It's changed if you look at the file diff but this comment is still here.
|
Just a few changes, all of which are very minor. |
|
This should be good to merge. |
ElDeveloper
added a commit
that referenced
this pull request
Jul 16, 2014
…data Add data_type_id column to preprocessed and processed data tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed because we want finer grain control over what datatype we are working with. Before this, we got it from raw data, which could potentially have multiple types (e.g. 16S and 18S in same run). Now we keep track of the datatype through the entire process.
This also has the required edits to the data objects to allow for addition of data_type upon creation and for getting both the text data_type and the data_type_id using, for example,
RawData.data_type(ret_id=True)