-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1912 #1948
fix #1912 #1948
Conversation
| ||
<button type="button" class="btn" data-toggle="collapse" data-target=".{{i}}collapsed">values</button> | ||
</td> | ||
{% for row in summary %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to expand the tuple here instead of indexing on lines 173 and 174?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure but if you feel strong about it, I can add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meh
I'm curious - what changed in the css files (the diff is too big to view). |
Oh ok. I think it is good then. |
By default the values are now hidden and you have to click on a "values" button so they are shown, see image below. This changed hit twbs/bootstrap#12593 so had to upgrade bootstrap.