You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Rust API for qirlib uses the &str type to represent OS-specific paths, such as the emit_ir method, but these slices are immediately converted into Path values.
These methods should be generalized to allow any type that supports Into<Path>, so that APIs which return Path values can be used with the trivial Into<T> for T impl but without breaking existing code that relies on passing &str slices.
The text was updated successfully, but these errors were encountered:
@cgranade - @SamarSha has started updating these to use impl AsRef<Path> which allows for &str to be passed. /home/iadavis/dev/pyqir/pyqir-jit/src/jit.rs:run_module_file for example.
The Rust API for
qirlib
uses the&str
type to represent OS-specific paths, such as theemit_ir
method, but these slices are immediately converted intoPath
values.These methods should be generalized to allow any type that supports
Into<Path>
, so that APIs which returnPath
values can be used with the trivialInto<T> for T
impl but without breaking existing code that relies on passing&str
slices.The text was updated successfully, but these errors were encountered: