Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some confusions about the code #79

Open
zqcrafts opened this issue Oct 29, 2023 · 2 comments
Open

Some confusions about the code #79

zqcrafts opened this issue Oct 29, 2023 · 2 comments

Comments

@zqcrafts
Copy link

Hello, authors, I really like your work.
There are two details in the code that confuse me.

  1. What does pe_deformed_grid = (deformed_grid + 0.3) / 1.6 do in train.py? How did we get this coefficient.
  2. In video_dataset.py, flow_tensor[..., 0] /= W_, flow_tensor[..., 1] /= H_ looks like it's inverted. Isn't flow_tensor[..., 0] horizontal? Also, aren't the optical flow outputs already normalized? What does this step do?
@qiuyu96
Copy link
Owner

qiuyu96 commented Oct 31, 2023

Please refer to this issue for more details.

@zqcrafts
Copy link
Author

Thanks for your kind reply. The problem 1 is addressed for me.
Could you explain problem 2 ? In my view, it seems computing inversely. Should it be "flow_tensor[..., 0] /= H_, flow_tensor[..., 1] /= W_" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants